Re: [PATCH 04/41] hw/intc/arm_gicv3: Report correct PIDR0 values for ID registers

[Richard Henderson]

On 4/8/22 07:15, Peter Maydell wrote:
> We use the common function gicv3_idreg() to supply the CoreSight ID
> register values for the GICv3 for the copies of these ID registers in
> the distributor, redistributor and ITS register frames.  This isn't
> quite correct, because while most of the register values are the
> same, the PIDR0 value should vary to indicate which of these three
> frames it is.  (You can see this and also the correct values of these
> PIDR0 registers by looking at the GIC-600 or GIC-700 TRMs, for
> example.)
>
> Make gicv3_idreg() take an extra argument for the PIDR0 value.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   hw/intc/gicv3_internal.h   | 15 +++++++++++++--
>   hw/intc/arm_gicv3_dist.c   |  2 +-
>   hw/intc/arm_gicv3_its.c    |  2 +-
>   hw/intc/arm_gicv3_redist.c |  2 +-
>   4 files changed, 16 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~