[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 09/24] target/arm: Enable FEAT_Debugv8p2 for -cpu max
From: |
Richard Henderson |
Subject: |
[PATCH v2 09/24] target/arm: Enable FEAT_Debugv8p2 for -cpu max |
Date: |
Mon, 11 Apr 2022 17:33:11 -0700 |
The only portion of FEAT_Debugv8p2 that is relevant to QEMU
is CONTEXTIDR_EL2, which is also conditionally implemented
with FEAT_VHE. The rest of the debug extension concerns the
External debug interface, which is outside the scope of QEMU.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
v2: Update emulation.rst
---
docs/system/arm/emulation.rst | 1 +
target/arm/cpu.c | 1 +
target/arm/cpu64.c | 1 +
target/arm/cpu_tcg.c | 2 ++
4 files changed, 5 insertions(+)
diff --git a/docs/system/arm/emulation.rst b/docs/system/arm/emulation.rst
index 520fd39071..035f7cf9d0 100644
--- a/docs/system/arm/emulation.rst
+++ b/docs/system/arm/emulation.rst
@@ -13,6 +13,7 @@ the following architecture extensions:
- FEAT_BTI (Branch Target Identification)
- FEAT_DIT (Data Independent Timing instructions)
- FEAT_DPB (DC CVAP instruction)
+- FEAT_Debugv8p2 (Debug changes for v8.2)
- FEAT_DotProd (Advanced SIMD dot product instructions)
- FEAT_FCMA (Floating-point complex number instructions)
- FEAT_FHM (Floating-point half-precision multiplication instructions)
diff --git a/target/arm/cpu.c b/target/arm/cpu.c
index 6521f350f9..d815d3a397 100644
--- a/target/arm/cpu.c
+++ b/target/arm/cpu.c
@@ -1800,6 +1800,7 @@ static void arm_cpu_realizefn(DeviceState *dev, Error
**errp)
* feature registers as well.
*/
cpu->isar.id_pfr1 = FIELD_DP32(cpu->isar.id_pfr1, ID_PFR1, SECURITY,
0);
+ cpu->isar.id_dfr0 = FIELD_DP32(cpu->isar.id_dfr0, ID_DFR0, COPSDBG, 0);
cpu->isar.id_aa64pfr0 = FIELD_DP64(cpu->isar.id_aa64pfr0,
ID_AA64PFR0, EL3, 0);
}
diff --git a/target/arm/cpu64.c b/target/arm/cpu64.c
index e4f630d83f..33570c3b6d 100644
--- a/target/arm/cpu64.c
+++ b/target/arm/cpu64.c
@@ -797,6 +797,7 @@ static void aarch64_max_initfn(Object *obj)
cpu->isar.id_aa64zfr0 = t;
t = cpu->isar.id_aa64dfr0;
+ t = FIELD_DP64(t, ID_AA64DFR0, DEBUGVER, 8); /* FEAT_Debugv8p2 */
t = FIELD_DP64(t, ID_AA64DFR0, PMUVER, 5); /* FEAT_PMUv3p4 */
cpu->isar.id_aa64dfr0 = t;
diff --git a/target/arm/cpu_tcg.c b/target/arm/cpu_tcg.c
index 075c187286..e719696412 100644
--- a/target/arm/cpu_tcg.c
+++ b/target/arm/cpu_tcg.c
@@ -75,6 +75,8 @@ void arm32_max_features(ARMCPU *cpu)
cpu->isar.id_pfr2 = t;
t = cpu->isar.id_dfr0;
+ t = FIELD_DP32(t, ID_DFR0, COPDBG, 8); /* FEAT_Debugv8p2 */
+ t = FIELD_DP32(t, ID_DFR0, COPSDBG, 8); /* FEAT_Debugv8p2 */
t = FIELD_DP32(t, ID_DFR0, PERFMON, 5); /* FEAT_PMUv3p4 */
cpu->isar.id_dfr0 = t;
}
--
2.25.1
- [PATCH v2 19/24] target/arm: Update ISAR fields for ARMv8.8, (continued)
- [PATCH v2 19/24] target/arm: Update ISAR fields for ARMv8.8, Richard Henderson, 2022/04/11
- [PATCH v2 10/24] target/arm: Enable FEAT_Debugv8p4 for -cpu max, Richard Henderson, 2022/04/11
- [PATCH v2 16/24] target/arm: Enable FEAT_RAS for -cpu max, Richard Henderson, 2022/04/11
- [PATCH v2 14/24] target/arm: Implement virtual SError exceptions, Richard Henderson, 2022/04/11
- [PATCH v2 18/24] target/arm: Enable FEAT_CSV2 for -cpu max, Richard Henderson, 2022/04/11
- [PATCH v2 21/24] target/arm: Enable FEAT_CSV3 for -cpu max, Richard Henderson, 2022/04/11
- [PATCH v2 05/24] target/arm: Set ID_DFR0.PerfMon for qemu-system-arm -cpu max, Richard Henderson, 2022/04/11
- [PATCH v2 06/24] target/arm: Split out arm32_max_features, Richard Henderson, 2022/04/11
- [PATCH v2 07/24] target/arm: Annotate arm_max_initfn with FEAT identifiers, Richard Henderson, 2022/04/11
- [PATCH v2 15/24] target/arm: Implement ESB instruction, Richard Henderson, 2022/04/11
- [PATCH v2 09/24] target/arm: Enable FEAT_Debugv8p2 for -cpu max,
Richard Henderson <=
- [PATCH v2 12/24] target/arm: Add minimal RAS registers, Richard Henderson, 2022/04/11
- [PATCH v2 11/24] target/arm: Add isar_feature_{aa64,any}_ras, Richard Henderson, 2022/04/11
- [PATCH v2 24/24] target/arm: Define neoverse-n1, Richard Henderson, 2022/04/11
- [PATCH v2 23/24] target/arm: Define cortex-a76, Richard Henderson, 2022/04/11
- [PATCH v2 20/24] target/arm: Enable FEAT_CSV2_2 for -cpu max, Richard Henderson, 2022/04/11
- [PATCH v2 22/24] target/arm: Enable FEAT_DGH for -cpu max, Richard Henderson, 2022/04/11