Re: [PATCH v5 3/4] hw/intc/exynos4210: replace 'qemu_split_irq' in combiner and gic

[Damien Hedde]

On 4/2/22 04:32, Zongyuan Li wrote:
> On Fri, Apr 1, 2022 at 9:17 PM Damien Hedde <damien.hedde@greensocs.com> wrote:
> > On 3/24/22 19:15, Zongyuan Li wrote:
> > > Signed-off-by: Zongyuan Li <zongyuan.li@smartx.com>
> > > ---
> > >    hw/arm/ .c           | 26 +++++++++++
> > >    hw/intc/exynos4210_combiner.c | 81 +++++++++++++++++++++++++++--------
> > >    hw/intc/exynos4210_gic.c      | 36 +++++++++++++---
> > >    include/hw/arm/exynos4210.h   | 11 ++---
> > >    include/hw/core/split-irq.h   |  5 +--
> > >    5 files changed, 126 insertions(+), 33 deletions(-)
> > >
> > > diff --git a/include/hw/core/split-irq.h b/include/hw/core/split-irq.h
> > > index ff8852f407..eb485dd7a6 100644
> > > --- a/include/hw/core/split-irq.h
> > > +++ b/include/hw/core/split-irq.h
> > > @@ -42,9 +42,6 @@
> > >
> > >    #define MAX_SPLIT_LINES 16
> > >
> > > -
> > > -OBJECT_DECLARE_SIMPLE_TYPE(SplitIRQ, SPLIT_IRQ)
> > > -
> > >    struct SplitIRQ {
> > >        DeviceState parent_obj;
> > >
> > > @@ -52,4 +49,6 @@ struct SplitIRQ {
> > >        uint16_t num_lines;
> > >    };
> > >
> > > +OBJECT_DECLARE_SIMPLE_TYPE(SplitIRQ, SPLIT_IRQ)
> > > +
> > >    #endif
>
> Some language servers may complain if we use forward declaration of
> struct and typedef.
>
> Regards,
> Li

Isn't that C-standard compliant code ?
We have that pattern all over the place in qemu.

Anyway I don't think that bit should be included in this patch about 
exynos4210.

--
Damien