[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Use field names for accessing DBGWCRn
From: |
Peter Maydell |
Subject: |
Re: [PATCH] target/arm: Use field names for accessing DBGWCRn |
Date: |
Thu, 28 Apr 2022 13:40:38 +0100 |
On Wed, 27 Apr 2022 at 06:22, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> While defining these names, use the correct field width of 5 not 4 for
> DBGWCR.MASK. This typo prevented setting a watchpoint larger than 32k.
>
> Reported-by: Chris Howard <cvz185@web.de>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/internals.h | 12 ++++++++++++
> target/arm/debug_helper.c | 10 +++++-----
> target/arm/helper.c | 8 ++++----
> target/arm/kvm64.c | 14 +++++++-------
> 4 files changed, 28 insertions(+), 16 deletions(-)
Applied to target-arm.next, thanks.
-- PMM