[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 2/5] hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 2/5] hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion |
Date: |
Wed, 11 Jan 2023 09:50:13 +0100 |
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/i2c/bitbang_i2c.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/i2c/bitbang_i2c.c b/hw/i2c/bitbang_i2c.c
index ac84bf0262..e41cb63daa 100644
--- a/hw/i2c/bitbang_i2c.c
+++ b/hw/i2c/bitbang_i2c.c
@@ -165,9 +165,10 @@ void bitbang_i2c_init(bitbang_i2c_interface *s, I2CBus
*bus)
OBJECT_DECLARE_SIMPLE_TYPE(GPIOI2CState, GPIO_I2C)
struct GPIOI2CState {
+ /*< private >*/
SysBusDevice parent_obj;
+ /*< public >*/
- MemoryRegion dummy_iomem;
bitbang_i2c_interface bitbang;
int last_level;
qemu_irq out;
@@ -188,12 +189,8 @@ static void gpio_i2c_init(Object *obj)
{
DeviceState *dev = DEVICE(obj);
GPIOI2CState *s = GPIO_I2C(obj);
- SysBusDevice *sbd = SYS_BUS_DEVICE(obj);
I2CBus *bus;
- memory_region_init(&s->dummy_iomem, obj, "gpio_i2c", 0);
- sysbus_init_mmio(sbd, &s->dummy_iomem);
-
bus = i2c_init_bus(dev, "i2c");
bitbang_i2c_init(&s->bitbang, bus);
--
2.38.1
- [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 1/5] hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 2/5] hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion,
Philippe Mathieu-Daudé <=
- [PATCH v3 3/5] hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state() helper, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 4/5] hw/i2c/bitbang_i2c: Trace state changes, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 5/5] hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events, Philippe Mathieu-Daudé, 2023/01/11
- Re: [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping, Corey Minyard, 2023/01/12
- Re: [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping, Laurent Vivier, 2023/01/16