[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping
From: |
Corey Minyard |
Subject: |
Re: [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping |
Date: |
Thu, 12 Jan 2023 09:33:09 -0600 |
On Wed, Jan 11, 2023 at 09:50:11AM +0100, Philippe Mathieu-Daudé wrote:
> Series fully reviewed.
These all look good to me
Acked-by: Corey Minyard <cminyard@mvista.com>
You mentioned the ARM tree, is this going in through there?
-corey
>
> Since v2:
> - Use array of const pointers to const (Richard)
>
> Since v1:
> - Fixed overwritten RECEIVING_BIT7 entry (Richard)
> - Picked R-b tags
>
> - Remove unused dummy MemoryRegion
> - Convert DPRINTF() to using trace events
>
> (series used as base for follow-up, better if merged via ARM tree)
>
> Philippe Mathieu-Daudé (5):
> hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header
> hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion
> hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state()
> helper
> hw/i2c/bitbang_i2c: Trace state changes
> hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events
>
> hw/arm/musicpal.c | 3 +-
> hw/i2c/bitbang_i2c.c | 80 ++++++++++++++++++++++--------------
> hw/i2c/trace-events | 7 ++++
> include/hw/i2c/bitbang_i2c.h | 2 +
> 4 files changed, 61 insertions(+), 31 deletions(-)
>
> --
> 2.38.1
>
>
- [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 1/5] hw/i2c/bitbang_i2c: Define TYPE_GPIO_I2C in public header, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 2/5] hw/i2c/bitbang_i2c: Remove unused dummy MemoryRegion, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 3/5] hw/i2c/bitbang_i2c: Change state calling bitbang_i2c_set_state() helper, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 4/5] hw/i2c/bitbang_i2c: Trace state changes, Philippe Mathieu-Daudé, 2023/01/11
- [PATCH v3 5/5] hw/i2c/bitbang_i2c: Convert DPRINTF() to trace events, Philippe Mathieu-Daudé, 2023/01/11
- Re: [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping,
Corey Minyard <=
- Re: [PATCH v3 0/5] hw/i2c/bitbang_i2c: Housekeeping, Laurent Vivier, 2023/01/16