[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error

From: Markus Armbruster
Subject: Re: [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error
Date: Wed, 18 Mar 2015 08:11:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

John Snow <address@hidden> writes:

> A thinko that clang 3.5.0 caught.
> Thankfully does not introduce any new failures.
> Signed-off-by: John Snow <address@hidden>

How you caught the bug is interesting enough to be mentioned in the
commit message, but the nature of the bug surely is more interesting
than that.  Suggest to change the subject to

    qtest/ahci: Fix a bit mask expression

Perhaps it can be fixed up on commit.

Reviewed-by: Markus Armbruster <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]