[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error

From: John Snow
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error
Date: Wed, 18 Mar 2015 10:23:36 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0

On 03/18/2015 03:11 AM, Markus Armbruster wrote:
John Snow <address@hidden> writes:

A thinko that clang 3.5.0 caught.
Thankfully does not introduce any new failures.

Signed-off-by: John Snow <address@hidden>

How you caught the bug is interesting enough to be mentioned in the
commit message, but the nature of the bug surely is more interesting
than that.  Suggest to change the subject to

     qtest/ahci: Fix a bit mask expression

Perhaps it can be fixed up on commit.

Reviewed-by: Markus Armbruster <address@hidden>

If it goes in through trivial,

can we change this to Markus's suggestion?

Thank you,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]