[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v5 0/2] block: Reject negative values for thrott

From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH v5 0/2] block: Reject negative values for throttling options
Date: Wed, 20 Jan 2016 09:07:35 +0100
User-agent: Notmuch/0.13.2 (http://notmuchmail.org) Emacs/23.2.1 (i486-pc-linux-gnu)

On Wed 20 Jan 2016 05:21:19 AM CET, Fam Zheng <address@hidden> wrote:
> v5: Add valid value testing in iotests. [Berto]
>     Add details in commit message. [Markus]
>     Use "%lld" in format string. [Markus]
>     Fix ")" -> "]" in error message. [Kevin]
> Now the negative values are silently converted to a huge positive number
> because we are doing implicit casting from uint64_t to double. Fix it and add 
> a
> test case (this was once fixed in 7d81c1413c9 but regressed when the block
> device option parsing code was changed).

Reviewed-by: Alberto Garcia <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]