[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] Replacing (and removing) get_ticks

From: rutuja shah
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <address@hidden>
Date: Fri, 11 Mar 2016 12:27:41 +0530

Thanks Eric. I will keep these points in mind while sending patches.
Rutuja Shah

On Fri, Mar 11, 2016 at 2:40 AM, Eric Blake <address@hidden> wrote:
> On 03/10/2016 12:30 PM, address@hidden wrote:
>> From: Rutuja Shah <address@hidden>
> Your commit message body was botched, cramming everything into the
> subject line.  Be sure you have a one-line summary (preferably shorter
> than 60 characters), then a blank line, before the rest of your
> description and S-o-b.  Also, it's good to say "why" in the commit body,
> not just "what".  Something like:
> maint: Drop unused get_ticks_per_sec()
> Replace the use of get_ticks_per_sec() with NANOSECONDS_PER_SECOND,
> because...
> Signed-off-by: Rutuja Shah <address@hidden>
> --
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]