[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] block: Remove bdrv_make_anon()

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH] block: Remove bdrv_make_anon()
Date: Wed, 23 Mar 2016 21:11:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0

On 18.03.2016 11:31, Kevin Wolf wrote:
> The call in hmp_drive_del() is dead code because blk_remove_bs() is
> called a few lines above.

Ah, so that's why I didn't have it in v3. Thanks for solving that
mystery for me. :-)

>                           The only other remaining user is
> bdrv_delete(), which only abuses bdrv_make_anon() to remove it from the
> named nodes list. This path inlines the list entry removal into
> bdrv_delete() and removes bdrv_make_anon().
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c               | 15 +++------------
>  blockdev.c            |  3 ---
>  include/block/block.h |  1 -
>  3 files changed, 3 insertions(+), 16 deletions(-)

Reviewed-by: Max Reitz <address@hidden>

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]