[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] Makefile: Derive "PKGVERSIO

From: Laszlo Ersek
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from "git describe" by default
Date: Wed, 1 Jun 2016 13:13:08 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0

On 06/01/16 12:40, Gerd Hoffmann wrote:
>   Hi,
>> +                            git describe 2>/dev/null | tr -d '\n'; \
>> +                            if ! git diff-index --quiet HEAD &>/dev/null; 
>> then \
>> +                                    printf -- '-dirty'; \
>> +                            fi \
> /me suggests "git describe --dirty --match 'v*'"
> Saves the extra effort to check for a dirty tree manually.

We couldn't convince ourselves that support for "--dirty" is ubiquitous;
please see the sub-thread rooted at

> Also greatly reduces the chance non-release tags are matched, so I don't
> get results like "pull-vga-20160523-1-236-g9fd5eb7".

Since what version is "--match" supported? ;)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]