[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/2] Let PKGVERSION include the

From: Changlong Xie
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v3 0/2] Let PKGVERSION include the "git describe" output
Date: Mon, 20 Jun 2016 12:50:40 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

For this patch, i think you forget to add qemu-version.h and/or qemu-version.h.tmp in .gitignore

changlox ~/w/qemu/qemu% gs
On branch master
Your branch is up-to-date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)


nothing added to commit but untracked files present (use "git add" to track)

On 06/01/2016 05:44 PM, Fam Zheng wrote:
v3: Use the "2.6.50 (v2.6.0-603-g684a494)" format. [Laszlo]
     printf '-dirty' -> printf -- '-dirty'.

v2: Address Eric's comments:
     "echo -n" -> "printf".
     "-unclean" -> "-dirty".

Makefile happened to be in my working set because of the docker test work, so I
went ahead to try this nice feature last evening before going to bed. My
apologies if we have duplicated work.

Please review, especially please comment on the redundant version string:

$ qemu-img --version
qemu-img version 2.6.50-v2.6.0-603-g684a494, Copyright (c) 2004-2008 Fabrice 

Fam Zheng (2):
   Makefile: Add a "FORCE" target
   Makefile: Derive "PKGVERSION" from "git describe" by default

  Makefile              | 24 ++++++++++++++++++++++--
  linux-user/main.c     |  1 +
  qemu-img.c            |  1 +
  qmp.c                 |  1 +
  scripts/create_config |  4 ----
  vl.c                  |  1 +
  6 files changed, 26 insertions(+), 6 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]