[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client |
Date: |
Mon, 27 Jun 2016 14:13:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 26/06/2016 00:15, Eric Blake wrote:
> diff --git a/block/nbd.c b/block/nbd.c
> index 8d57220..049d1bd 100644
> --- a/block/nbd.c
> +++ b/block/nbd.c
> @@ -357,6 +357,7 @@ static int nbd_co_flush(BlockDriverState *bs)
> static void nbd_refresh_limits(BlockDriverState *bs, Error **errp)
> {
> bs->bl.max_pdiscard = NBD_MAX_BUFFER_SIZE;
> + bs->bl.max_pwrite_zeroes = NBD_MAX_BUFFER_SIZE;
I have probably asked before---is there any reason for these to be
limited, since the commands have no payload?
Thanks,
Paolo
> bs->bl.max_transfer = NBD_MAX_BUFFER_SIZE;
> }
- [Qemu-block] [PATCH v4 08/14] nbd: Let server know when client gives up negotiation, (continued)
- [Qemu-block] [PATCH v4 08/14] nbd: Let server know when client gives up negotiation, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 02/14] nbd: Add qemu-nbd -D for human-readable description, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 03/14] nbd: Limit nbdflags to 16 bits, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 05/14] nbd: Share common reply-sending code in server, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 06/14] nbd: Send message along with server NBD_REP_ERR errors, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 11/14] nbd: Support shorter handshake, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 07/14] nbd: Share common option-sending code in client, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 12/14] nbd: Improve server handling of shutdown requests, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client, Eric Blake, 2016/06/25
- Re: [Qemu-block] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client,
Paolo Bonzini <=
- [Qemu-block] [PATCH v4 04/14] nbd: Treat flags vs. command type as separate fields, Eric Blake, 2016/06/25
- [Qemu-block] [PATCH v4 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server, Eric Blake, 2016/06/25