[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v4 10/14] nbd: Less allocation during NBD_OPT_LI

From: Paolo Bonzini
Subject: Re: [Qemu-block] [PATCH v4 10/14] nbd: Less allocation during NBD_OPT_LIST
Date: Mon, 27 Jun 2016 14:16:04 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1

On 26/06/2016 00:15, Eric Blake wrote:
> +/* Return -1 if unrecoverable error occurs
> , 0 if NBD_OPT_LIST is unsupported,

These two should return errp != NULL and negative errno.

> 1 if iteration is done
> 2 to keep looking,
> and 3 if * this entry matches @want. */

These three should return errp == NULL.  Please change the function so
that the return value signifies "need another call", and a bool*
argument is set to true if the name matches.


> +static int nbd_receive_list(QIOChannel *ioc, const char *want, Error **errp)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]