[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 10/18] block: Move 'discard' option
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common() |
|
Date: |
Fri, 7 Oct 2016 12:20:37 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 07.10.2016 um 11:01 hat Gerd Hoffmann geschrieben:
> On Di, 2016-09-27 at 15:53 +0200, Kevin Wolf wrote:
> > This enables its use for nested child nodes. The compatibility
> > between the 'discard' and 'detect-zeroes' setting is checked in
> > bdrv_open_common() now as the former setting isn't available before
> > calling bdrv_open() any more.
>
> Seems this change makes libvirt not see the discard option any more,
> "virsh start" throws this error now ...
>
> error: Failed to start domain fedora-org-xhci
> error: unsupported configuration: discard is not supported by this QEMU
> binary
>
> ... and git bisect found this commit.
The fix is already on the list:
[PATCH] block: Add bdrv_runtime_opts to query-command-line-options
Kevin