[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 02/12] blockjob: remove iostatus_reset callback
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PULL 02/12] blockjob: remove iostatus_reset callback |
Date: |
Fri, 26 May 2017 15:23:54 -0400 |
From: Paolo Bonzini <address@hidden>
This is unused since commit 66a0fae ("blockjob: Don't touch BDS iostatus",
2016-05-19).
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Jeff Cody <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>
---
blockjob.c | 3 ---
include/block/blockjob_int.h | 3 ---
2 files changed, 6 deletions(-)
diff --git a/blockjob.c b/blockjob.c
index 23022b3..71187d0 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -555,9 +555,6 @@ bool block_job_is_cancelled(BlockJob *job)
void block_job_iostatus_reset(BlockJob *job)
{
job->iostatus = BLOCK_DEVICE_IO_STATUS_OK;
- if (job->driver->iostatus_reset) {
- job->driver->iostatus_reset(job);
- }
}
static int block_job_finish_sync(BlockJob *job,
diff --git a/include/block/blockjob_int.h b/include/block/blockjob_int.h
index 3f86cc5..bfcc5d1 100644
--- a/include/block/blockjob_int.h
+++ b/include/block/blockjob_int.h
@@ -44,9 +44,6 @@ struct BlockJobDriver {
/** Optional callback for job types that support setting a speed limit */
void (*set_speed)(BlockJob *job, int64_t speed, Error **errp);
- /** Optional callback for job types that need to forward I/O status reset
*/
- void (*iostatus_reset)(BlockJob *job);
-
/** Mandatory: Entrypoint for the Coroutine. */
CoroutineEntry *start;
--
2.9.3
- [Qemu-block] [PULL 00/12] Block patches, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 01/12] blockjob: remove unnecessary check, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 02/12] blockjob: remove iostatus_reset callback,
Jeff Cody <=
- [Qemu-block] [PULL 03/12] blockjob: introduce block_job_early_fail, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 05/12] blockjob: separate monitor and blockjob APIs, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 04/12] blockjob: introduce block_job_pause/resume_all, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 08/12] blockjob: group BlockJob transaction functions together, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 07/12] blockjob: introduce block_job_cancel_async, check iostatus invariants, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 06/12] blockjob: move iostatus reset inside block_job_user_resume, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 09/12] blockjob: strengthen a bit test-blockjob-txn, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 10/12] blockjob: reorganize block_job_completed_txn_abort, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 11/12] blockjob: use deferred_to_main_loop to indicate the coroutine has ended, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 12/12] block/gluster: glfs_lseek() workaround, Jeff Cody, 2017/05/26