[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PULL 09/12] blockjob: strengthen a bit test-blockjob-txn
From: |
Jeff Cody |
Subject: |
[Qemu-block] [PULL 09/12] blockjob: strengthen a bit test-blockjob-txn |
Date: |
Fri, 26 May 2017 15:24:01 -0400 |
From: Paolo Bonzini <address@hidden>
Unlike test-blockjob-txn, QMP releases the reference to the transaction
before the jobs finish. Thus, qemu-iotest 124 showed a failure while
working on the next patch that the unit tests did not have. Make
the test a little nastier.
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Jeff Cody <address@hidden>
---
tests/test-blockjob-txn.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/tests/test-blockjob-txn.c b/tests/test-blockjob-txn.c
index 0f80194..c77343f 100644
--- a/tests/test-blockjob-txn.c
+++ b/tests/test-blockjob-txn.c
@@ -167,6 +167,11 @@ static void test_pair_jobs(int expected1, int expected2)
block_job_start(job1);
block_job_start(job2);
+ /* Release our reference now to trigger as many nice
+ * use-after-free bugs as possible.
+ */
+ block_job_txn_unref(txn);
+
if (expected1 == -ECANCELED) {
block_job_cancel(job1);
}
@@ -187,8 +192,6 @@ static void test_pair_jobs(int expected1, int expected2)
g_assert_cmpint(result1, ==, expected1);
g_assert_cmpint(result2, ==, expected2);
-
- block_job_txn_unref(txn);
}
static void test_pair_jobs_success(void)
--
2.9.3
- [Qemu-block] [PULL 00/12] Block patches, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 01/12] blockjob: remove unnecessary check, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 02/12] blockjob: remove iostatus_reset callback, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 03/12] blockjob: introduce block_job_early_fail, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 05/12] blockjob: separate monitor and blockjob APIs, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 04/12] blockjob: introduce block_job_pause/resume_all, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 08/12] blockjob: group BlockJob transaction functions together, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 07/12] blockjob: introduce block_job_cancel_async, check iostatus invariants, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 06/12] blockjob: move iostatus reset inside block_job_user_resume, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 09/12] blockjob: strengthen a bit test-blockjob-txn,
Jeff Cody <=
- [Qemu-block] [PULL 10/12] blockjob: reorganize block_job_completed_txn_abort, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 11/12] blockjob: use deferred_to_main_loop to indicate the coroutine has ended, Jeff Cody, 2017/05/26
- [Qemu-block] [PULL 12/12] block/gluster: glfs_lseek() workaround, Jeff Cody, 2017/05/26
- Re: [Qemu-block] [PULL 00/12] Block patches, Stefan Hajnoczi, 2017/05/30