[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./
Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README
Fri, 21 Jul 2017 07:16:34 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote:
> There is not much getting started documentation for qemu-iotests. This
> patch explains how to create a new test and covers the overall testing
> Cc: Ishani Chugh <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> +3. Assign groups to the test
> +Add your test to the ./group file. This file is the index of tests and
> +them to functional groups like "rw" for read-write tests. Most tests belong
> +the "rw" and "auto" groups. "auto" means the test runs when ./check is
> +without a -g argument.
> +Consider adding your test to the "quick" group if it executes quickly (<1s).
We have several tests going up to 5s (and I have a patch pending to
remove two tests that took longer) - I think 1s is a bit on the short
end for still classifying a test as quick.
> +This group is run by "make check-block" and is often included as part of
> +tests in continuous integration systems.
It would still be nice to have 'make check' run 'make check-block'...
but that's independent of this patch.
> +Once you are happy with the test output it can be used as the golden master
> +with "mv <test-number>.out.bad <test-number>.out". Rerun the test to verify
> +that it passes.
> +Congratulations, you've created a new test!
Maybe a reminder to 'git add' the new files, then submit the patch?
Better than what we have, so whether or not you make further tweaks
according to my suggestions,
Reviewed-by: Eric Blake <address@hidden>
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
Description: OpenPGP digital signature