[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./

From: John Snow
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README
Date: Mon, 24 Jul 2017 17:50:39 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 07/21/2017 11:51 AM, Stefan Hajnoczi wrote:
On Fri, Jul 21, 2017 at 07:16:34AM -0500, Eric Blake wrote:
On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote:
There is not much getting started documentation for qemu-iotests.  This
patch explains how to create a new test and covers the overall testing

Cc: Ishani Chugh <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>

+3. Assign groups to the test
+Add your test to the ./group file.  This file is the index of tests and assigns
+them to functional groups like "rw" for read-write tests.  Most tests belong to
+the "rw" and "auto" groups.  "auto" means the test runs when ./check is invoked
+without a -g argument.
+Consider adding your test to the "quick" group if it executes quickly (<1s).

We have several tests going up to 5s (and I have a patch pending to
remove two tests that took longer) - I think 1s is a bit on the short
end for still classifying a test as quick.

I'm happy to accept any number blessed by Kevin.  I do think that 1
second is a safe maximum and no one should get in trouble for adding a
test that takes 1 second to the "quick" group.

+This group is run by "make check-block" and is often included as part of build
+tests in continuous integration systems.

It would still be nice to have 'make check' run 'make check-block'...
but that's independent of this patch.

Yes, there is a separate discussion about that on the list right now.
Hopefully it will be added back.

If we do, it'd be nice to have a `make check-block-alt` or something else that checks the exact set of tests not covered by `make check-block`.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]