[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 3/7] qcow2: Check L1 table parameters in qcow2_e

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 3/7] qcow2: Check L1 table parameters in qcow2_expand_zero_clusters()
Date: Thu, 1 Mar 2018 17:39:08 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/01/2018 10:27 AM, Alberto Garcia wrote:
This function iterates over all snapshots of a qcow2 file in order to
expand all zero clusters, but it does not validate the snapshots' L1
tables first.

We now have a function to take care of this, so let's use it.

We can also take the opportunity to replace the sector-based
bdrv_read() with bdrv_pread().

Doesn't my pending patch do that as well?

I guess it remains to be seen in what order these patches are merged.

Signed-off-by: Alberto Garcia <address@hidden>
  block/qcow2-cluster.c      | 20 +++++++++++++-------
  tests/qemu-iotests/080     |  2 ++
  tests/qemu-iotests/080.out |  2 ++
  3 files changed, 17 insertions(+), 7 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]