[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 3/7] qcow: Support .bdrv_co_create

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 3/7] qcow: Support .bdrv_co_create
Date: Wed, 14 Mar 2018 06:16:18 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0

On 03/09/2018 03:46 PM, Kevin Wolf wrote:
This adds the .bdrv_co_create driver callback to qcow, which
enables image creation over QMP.

Signed-off-by: Kevin Wolf <address@hidden>
  qapi/block-core.json |  21 +++++-
  block/qcow.c         | 196 ++++++++++++++++++++++++++++++++++-----------------
  2 files changed, 150 insertions(+), 67 deletions(-)

+# @BlockdevCreateOptionsQcow:
+# Driver specific image creation options for qcow.
+# @file             Node to create the image format on
+# @size             Size of the virtual disk in bytes
+# @backing-file     File name of the backing file if a backing file
+#                   should be used
+# @encrypt          Encryption options if the image should be encrypted

Idea for followup patch - we should strongly document that encryption of qcow is discouraged as insecure, and/or mention that qcow2 is generally a better option than qcow when creating images over QMP.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]