[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 1/9] qemu-io: Fix writethrough check in reopen
From: |
Alberto Garcia |
Subject: |
[Qemu-block] [PATCH 1/9] qemu-io: Fix writethrough check in reopen |
Date: |
Sun, 26 Aug 2018 17:09:32 +0300 |
"qemu-io reopen" doesn't allow changing the writethrough setting of
the cache, but the check is wrong, causing an error even on a simple
reopen with the default parameters:
$ qemu-img create -f qcow2 hd.qcow2 1M
$ qemu-system-x86_64 -monitor stdio -drive if=virtio,file=hd.qcow2
(qemu) qemu-io virtio0 reopen
Cannot change cache.writeback: Device attached
Signed-off-by: Alberto Garcia <address@hidden>
---
qemu-io-cmds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index 5bf5f28178..db0b3ee5ef 100644
--- a/qemu-io-cmds.c
+++ b/qemu-io-cmds.c
@@ -2025,7 +2025,7 @@ static int reopen_f(BlockBackend *blk, int argc, char
**argv)
return -EINVAL;
}
- if (writethrough != blk_enable_write_cache(blk) &&
+ if (!writethrough != blk_enable_write_cache(blk) &&
blk_get_attached_dev(blk))
{
error_report("Cannot change cache.writeback: Device attached");
--
2.11.0
- [Qemu-block] [PATCH 0/9] Misc reopen-related patches, Alberto Garcia, 2018/08/26
- [Qemu-block] [PATCH 2/9] file-posix: x-check-cache-dropped should default to false on reopen, Alberto Garcia, 2018/08/26
- [Qemu-block] [PATCH 1/9] qemu-io: Fix writethrough check in reopen,
Alberto Garcia <=
- [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Alberto Garcia, 2018/08/26
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Alberto Garcia, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Alberto Garcia, 2018/08/29
- Re: [Qemu-block] [PATCH 5/9] block: Allow child references on reopen, Max Reitz, 2018/08/29
[Qemu-block] [PATCH 8/9] block: Allow changing 'detect-zeroes' on reopen, Alberto Garcia, 2018/08/26