[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 4/9] block/commit: utilize job_exit shim
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 4/9] block/commit: utilize job_exit shim |
Date: |
Mon, 27 Aug 2018 12:28:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-08-24 00:08, John Snow wrote:
> Change the manual deferment to commit_complete into the implicit
> callback to job_exit, renaming commit_complete to commit_exit.
>
> This conversion does change the timing of when job_completed is
> called to after the bdrv_replace_node and bdrv_unref calls, which
> could have implications for bjob->blk which will now be put down
> after this cleanup.
>
> Kevin highlights that we did not take any permissions for that backend
> at job creation time, so it is safe to reorder these operations.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> block/commit.c | 22 +++++-----------------
> 1 file changed, 5 insertions(+), 17 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 8/9] jobs: remove ret argument to job_completed; privatize it, (continued)
- [Qemu-block] [PATCH v2 8/9] jobs: remove ret argument to job_completed; privatize it, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 6/9] jobs: utilize job_exit shim, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 9/9] jobs: remove job_defer_to_main_loop, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 7/9] block/backup: make function variables consistently named, John Snow, 2018/08/23
- [Qemu-block] [PATCH v2 4/9] block/commit: utilize job_exit shim, John Snow, 2018/08/23
- Re: [Qemu-block] [PATCH v2 4/9] block/commit: utilize job_exit shim,
Max Reitz <=
- [Qemu-block] [PATCH v2 1/9] jobs: change start callback to run callback, John Snow, 2018/08/23