[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not har
From: |
Thomas Huth |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 3/6] tests/qemu-iotests: Do not hard-code the path to bash |
Date: |
Thu, 25 Apr 2019 09:48:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 24/04/2019 17.23, Daniel P. Berrangé wrote:
> On Wed, Apr 24, 2019 at 09:14:29AM -0500, Eric Blake wrote:
>> On 4/24/19 5:37 AM, Thomas Huth wrote:
>>> bash is installed in a different directory on non-Linux systems like
>>> FreeBSD. Do not hard-code /bin/bash here so that the tests can run
>>> there, too.
>>
>> These tests were obviously copy-and-pasted from a fork point prior to
>> commit 11a82d14.
>
> Is this a candidate for a checkpatch addition to reject any use
> of /bin/bash in scripts ?
Not sure whether we should really reject it with an error (there might
be scripts that are only used on Linux anyway), but checkpatch.pl should
at least print a warning, I think.
Thomas
[Qemu-block] [PATCH 2/6] tests/qemu-iotests/group: Introduce a new "ci" group for CI pipelines, Thomas Huth, 2019/04/24