qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] lockable: replaced locks with lock guard macros where approp


From: Daniel Brodsky
Subject: Re: [PATCH] lockable: replaced locks with lock guard macros where appropriate
Date: Thu, 19 Mar 2020 15:15:06 -0700

On Thu, Mar 19, 2020 at 1:53 PM Eric Blake <address@hidden> wrote:

Hmm. This one is a different failure than the other patchew warnings
about variable redefinition; but is still evidence that it is missing
your "[PATCH] misc: fix __COUNTER__ macro to be referenced properly".
At any rate, the fact that we have a compiler warning about an unused
variable (when in reality it IS used by the auto-cleanup attribute) is
annoying; we may have to further tweak QEMU_LOCK_GUARD to add an
__attribute__((unused)) to shut up this particular compiler false positive.

This might fix itself once I revise the patch to properly reference the prior patch
before this one. If not then I can add another patch to get rid of the false positive.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]