[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device |
|
Date: |
Mon, 6 Apr 2020 10:25:17 +0200 |
On Fri, Apr 03, 2020 at 12:09:21PM +0200, Igor Mammedov wrote:
> On Fri, 3 Apr 2020 10:04:57 +0200
> Gerd Hoffmann <address@hidden> wrote:
>
> > Signed-off-by: Gerd Hoffmann <address@hidden>
> > ---
> [...]
> > +static void rtc_build_aml(ISADevice *isadev, Aml *scope)
> > +{
> > + Aml *dev;
> > + Aml *crs;
> > +
> > + crs = aml_resource_template();
> > + aml_append(crs, aml_io(AML_DECODE16, 0x0070, 0x0070, 0x10, 0x02));
> > + aml_append(crs, aml_irq_no_flags(8));
> > + aml_append(crs, aml_io(AML_DECODE16, 0x0072, 0x0072, 0x02, 0x06));
>
> since this is made a part of device, can we fetch io port values from
> device instead of hard-codding values here?
No, the rtc device hasn't a configurable io port address.
cheers,
Gerd
- [PATCH v2 02/12] acpi: add aml builder stubs, (continued)
- [PATCH v2 02/12] acpi: add aml builder stubs, Gerd Hoffmann, 2020/04/03
- [PATCH v2 01/12] move 'typedef Aml' to qemu/types.h, Gerd Hoffmann, 2020/04/03
- [PATCH v2 12/12] acpi: factor out fw_cfg_add_acpi_dsdt(), Gerd Hoffmann, 2020/04/03
- [PATCH v2 04/12] acpi: serial: don't use _STA method, Gerd Hoffmann, 2020/04/03
- [PATCH v2 07/12] acpi: move aml builder code for rtc device, Gerd Hoffmann, 2020/04/03
- Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device, Igor Mammedov, 2020/04/03
- Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device,
Gerd Hoffmann <=
- Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device, Igor Mammedov, 2020/04/06
- Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device, Gerd Hoffmann, 2020/04/07
- Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device, Igor Mammedov, 2020/04/08
- Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device, Gerd Hoffmann, 2020/04/08
- Re: [PATCH v2 07/12] acpi: move aml builder code for rtc device, Cameron Esfahani, 2020/04/08
[PATCH v2 08/12] acpi: move aml builder code for serial device, Gerd Hoffmann, 2020/04/03
[PATCH v2 05/12] acpi: parallel: don't use _STA method, Gerd Hoffmann, 2020/04/03
[PATCH v2 09/12] acpi: move aml builder code for parallel device, Gerd Hoffmann, 2020/04/03