Re: [PATCH 09/46] error: Avoid error_propagate() after migrate_add_blocker()

[Eric Blake]

On 6/24/20 11:43 AM, Markus Armbruster wrote:
> When migrate_add_blocker(blocker, &errp) is followed by
> error_propagate(errp, err), we can often just as well do
> migrate_add_blocker(..., errp).
>
> Do that with this Coccinelle script:

> Double-check @err is not used afterwards.  Dereferencing it would be
> use after free, but checking whether it's null would be legitimate.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org