[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3] hw/block/nvme: add device self test command support
From: |
Keith Busch |
Subject: |
Re: [PATCH v3] hw/block/nvme: add device self test command support |
Date: |
Sat, 10 Apr 2021 00:35:20 +0900 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Wed, Mar 31, 2021 at 02:54:27PM +0530, Gollu Appalanaidu wrote:
> This is to add support for Device Self Test Command (DST) and
> DST Log Page. Refer NVM Express specification 1.4b section 5.8
> ("Device Self-test command")
Please don't write change logs that just say what you did. I can read
the code to see that. Explain why this is useful because this frankly
looks like another useless feature. We don't need to implement every
optional spec feature here. There should be a real value proposition.
- Re: [PATCH v3] hw/block/nvme: add device self test command support,
Keith Busch <=