[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 06/16] job.c: make job_event_* functions static
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v3 06/16] job.c: make job_event_* functions static |
Date: |
Wed, 5 Jan 2022 09:01:58 -0500 |
job_event_* functions can all be static, as they are not used
outside job.c.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
include/qemu/job.h | 6 ------
job.c | 12 ++++++++++--
2 files changed, 10 insertions(+), 8 deletions(-)
diff --git a/include/qemu/job.h b/include/qemu/job.h
index f800b0b881..c95f9fa8d1 100644
--- a/include/qemu/job.h
+++ b/include/qemu/job.h
@@ -454,12 +454,6 @@ void job_progress_set_remaining(Job *job, uint64_t
remaining);
*/
void job_progress_increase_remaining(Job *job, uint64_t delta);
-/** To be called when a cancelled job is finalised. */
-void job_event_cancelled(Job *job);
-
-/** To be called when a successfully completed job is finalised. */
-void job_event_completed(Job *job);
-
/**
* Conditionally enter the job coroutine if the job is ready to run, not
* already busy and fn() returns true. fn() is called while under the job_lock
diff --git a/job.c b/job.c
index f4e1a56705..b0dba40728 100644
--- a/job.c
+++ b/job.c
@@ -498,12 +498,20 @@ void job_progress_increase_remaining(Job *job, uint64_t
delta)
progress_increase_remaining(&job->progress, delta);
}
-void job_event_cancelled(Job *job)
+/**
+ * To be called when a cancelled job is finalised.
+ * Called with job_mutex held.
+ */
+static void job_event_cancelled(Job *job)
{
notifier_list_notify(&job->on_finalize_cancelled, job);
}
-void job_event_completed(Job *job)
+/**
+ * To be called when a successfully completed job is finalised.
+ * Called with job_mutex held.
+ */
+static void job_event_completed(Job *job)
{
notifier_list_notify(&job->on_finalize_completed, job);
}
--
2.31.1
- [PATCH v3 01/16] job.c: make job_mutex and job_lock/unlock() public, (continued)
- [PATCH v3 01/16] job.c: make job_mutex and job_lock/unlock() public, Emanuele Giuseppe Esposito, 2022/01/05
- [PATCH v3 02/16] job.h: categorize fields in struct Job, Emanuele Giuseppe Esposito, 2022/01/05
- [PATCH v3 05/16] block/mirror.c: use of job helpers in drivers to avoid TOC/TOU, Emanuele Giuseppe Esposito, 2022/01/05
- [PATCH v3 08/16] aio-wait.h: introduce AIO_WAIT_WHILE_UNLOCKED, Emanuele Giuseppe Esposito, 2022/01/05
- [PATCH v3 07/16] job.c: move inner aiocontext lock in callbacks, Emanuele Giuseppe Esposito, 2022/01/05
- [PATCH v3 11/16] jobs: document all static functions and add _locked() suffix, Emanuele Giuseppe Esposito, 2022/01/05
- [PATCH v3 06/16] job.c: make job_event_* functions static,
Emanuele Giuseppe Esposito <=
- [PATCH v3 15/16] job.c: enable job lock/unlock and remove Aiocontext locks, Emanuele Giuseppe Esposito, 2022/01/05
- [PATCH v3 14/16] job.c: use job_get_aio_context(), Emanuele Giuseppe Esposito, 2022/01/05
[PATCH v3 13/16] jobs: add job lock in find_* functions, Emanuele Giuseppe Esposito, 2022/01/05