qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 16/16] block_job_query: remove atomic read


From: Paolo Bonzini
Subject: Re: [PATCH v3 16/16] block_job_query: remove atomic read
Date: Wed, 19 Jan 2022 11:34:47 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0

On 1/5/22 15:02, Emanuele Giuseppe Esposito wrote:
+++ b/blockjob.c
@@ -335,13 +335,13 @@ BlockJobInfo *block_job_query(BlockJob *job, Error **errp)
      info = g_new0(BlockJobInfo, 1);
      info->type      = g_strdup(job_type_str(&job->job));
      info->device    = g_strdup(job->job.id);
-    info->busy      = qatomic_read(&job->job.busy);
+    info->busy      = job->job.busy;
      info->paused    = job->job.pause_count > 0;
      info->offset    = progress_current;
      info->len       = progress_total;
      info->speed     = job->speed;
      info->io_status = job->iostatus;
-    info->ready     = job_is_ready(&job->job),
+    info->ready     = job_is_ready_locked(&job->job),

This second part belongs earlier in the series, I think?

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]