Re: [PATCH 04/26] coroutine: remove incorrect coroutine_fn annotations

[Eric Blake]

On Fri, Apr 15, 2022 at 03:18:38PM +0200, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Again, a short summary why it is correct is helpful.

> ---
>  include/qemu/coroutine.h | 2 +-
>  util/qemu-coroutine.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/qemu/coroutine.h b/include/qemu/coroutine.h
> index 284571badb..2d9211faff 100644
> --- a/include/qemu/coroutine.h
> +++ b/include/qemu/coroutine.h
> @@ -92,7 +92,7 @@ void coroutine_fn qemu_coroutine_yield(void);
>  /**
>   * Get the AioContext of the given coroutine
>   */
> -AioContext *coroutine_fn qemu_coroutine_get_aio_context(Coroutine *co);
> +AioContext *qemu_coroutine_get_aio_context(Coroutine *co);

Here, the intent is that this function is safe to call even when not
in a coroutine, and the annotation is only needed when it is required
that the caller already be in a coroutine.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org