Re: [PATCH 01/26] block: remove incorrect coroutine_fn annotations

[Stefan Hajnoczi]

On Tue, Apr 19, 2022 at 12:57:54PM -0500, Eric Blake wrote:
> On Fri, Apr 15, 2022 at 03:18:35PM +0200, Paolo Bonzini wrote:
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Might be nice to document in the commit message why the annotation was
> incorrect, so someone stumbling across this commit in a bisect but
> otherwise unfamiliar with the rules of when to annotate doesn't get
> lost.  If I understand right, the argument is more-or-less:
> 
> This function defers to the generated blk_do_pwritev_part, which is
> safe to call outside coroutine context.
> 
> But although the commit message is weak, the change itself appears
> correct from what I have observed with the annotation in other places.
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

Yes, please! I'm also wondering how to review a patch like this because
I can only infer the meaning and audit the code myself to check my guess.

Stefan

signature.asc
Description: PGP signature