[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 16/24] tests: Ensure TAP version is printed before other messa
From: |
Alex Bennée |
Subject: |
[PATCH v3 16/24] tests: Ensure TAP version is printed before other messages |
Date: |
Tue, 28 Feb 2023 19:06:45 +0000 |
From: "Richard W.M. Jones" <rjones@redhat.com>
These two tests were failing with this error:
stderr:
TAP parsing error: version number must be on the first line
[...]
Unknown TAP version. The first line MUST be `TAP version <int>`. Assuming
version 12.
This can be fixed by ensuring we always call g_test_init first in the
body of main.
Thanks: Daniel Berrange, for diagnosing the problem
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Alexander Bulekov <alxndr@bu.edu>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Message-Id: <20230227174019.1164205-1-rjones@redhat.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/qtest/fuzz-lsi53c895a-test.c | 4 ++--
tests/qtest/rtl8139-test.c | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/fuzz-lsi53c895a-test.c
b/tests/qtest/fuzz-lsi53c895a-test.c
index a9254b455d..2012bd54b7 100644
--- a/tests/qtest/fuzz-lsi53c895a-test.c
+++ b/tests/qtest/fuzz-lsi53c895a-test.c
@@ -112,12 +112,12 @@ static void test_lsi_do_dma_empty_queue(void)
int main(int argc, char **argv)
{
+ g_test_init(&argc, &argv, NULL);
+
if (!qtest_has_device("lsi53c895a")) {
return 0;
}
- g_test_init(&argc, &argv, NULL);
-
qtest_add_func("fuzz/lsi53c895a/lsi_do_dma_empty_queue",
test_lsi_do_dma_empty_queue);
diff --git a/tests/qtest/rtl8139-test.c b/tests/qtest/rtl8139-test.c
index 1beb83805c..4bd240e9ee 100644
--- a/tests/qtest/rtl8139-test.c
+++ b/tests/qtest/rtl8139-test.c
@@ -207,9 +207,10 @@ int main(int argc, char **argv)
verbosity_level = atoi(v_env);
}
+ g_test_init(&argc, &argv, NULL);
+
qtest_start("-device rtl8139");
- g_test_init(&argc, &argv, NULL);
qtest_add_func("/rtl8139/nop", nop);
qtest_add_func("/rtl8139/timer", test_init);
--
2.39.2
- [PATCH v3 01/24] tests: don't run socat tests on MacOS as well, (continued)
- [PATCH v3 01/24] tests: don't run socat tests on MacOS as well, Alex Bennée, 2023/02/28
- [PATCH v3 04/24] tests: make fp-test less chatty when running from test suite, Alex Bennée, 2023/02/28
- [PATCH v3 05/24] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs, Alex Bennée, 2023/02/28
- [PATCH v3 10/24] tests: add tuxrun baseline test to avocado, Alex Bennée, 2023/02/28
- [PATCH v3 03/24] tests: be a bit more strict cleaning up fifos, Alex Bennée, 2023/02/28
- [PATCH v3 08/24] testing: update ubuntu2004 to ubuntu2204, Alex Bennée, 2023/02/28
- [PATCH v3 02/24] tests: add socat dependency for tests, Alex Bennée, 2023/02/28
- [PATCH v3 07/24] tests: don't run benchmarks for the tsan build, Alex Bennée, 2023/02/28
- [PATCH v3 06/24] gitlab: extend custom runners with base_job_template, Alex Bennée, 2023/02/28
- [PATCH v3 14/24] tests/dockerfiles: unify debian-toolchain references, Alex Bennée, 2023/02/28
- [PATCH v3 16/24] tests: Ensure TAP version is printed before other messages,
Alex Bennée <=
- [PATCH v3 15/24] gitlab: Use plain docker in container-template.yml, Alex Bennée, 2023/02/28
- [PATCH v3 09/24] tests: skip the nios2 replay_kernel test, Alex Bennée, 2023/02/28
- [PATCH v3 12/24] tests: ensure we export job results for some cross builds, Alex Bennée, 2023/02/28
- [PATCH v3 11/24] tests/docker: Use binaries for debian-tricore-cross, Alex Bennée, 2023/02/28
- [PATCH v3 19/24] tests/docker: add USER stanzas to non-lci images, Alex Bennée, 2023/02/28
- [PATCH v3 13/24] cirrus.yml: Improve the windows_msys2_task, Alex Bennée, 2023/02/28
- [PATCH v3 21/24] tests/docker: use direct RUNC call to run test jobs, Alex Bennée, 2023/02/28
- [PATCH v3 20/24] tests/docker: use direct RUNC call to build containers, Alex Bennée, 2023/02/28
- [PATCH v3 24/24] tests/avocado: disable BootLinuxPPC64 test in CI, Alex Bennée, 2023/02/28