[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 6e288b: rcu: remove qatomic_mb_set, expand co
|
From: |
Richard Henderson |
|
Subject: |
[Qemu-commits] [qemu/qemu] 6e288b: rcu: remove qatomic_mb_set, expand comments |
|
Date: |
Tue, 09 May 2023 07:22:07 -0700 |
Branch: refs/heads/staging
Home: https://github.com/qemu/qemu
Commit: 6e288b00ef536f87910f76cb1940a8caced69c54
https://github.com/qemu/qemu/commit/6e288b00ef536f87910f76cb1940a8caced69c54
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M include/qemu/rcu.h
M util/rcu.c
Log Message:
-----------
rcu: remove qatomic_mb_set, expand comments
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 4f7335e21d5170986e20001b9ddb906fe24413f1
https://github.com/qemu/qemu/commit/4f7335e21d5170986e20001b9ddb906fe24413f1
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M tests/unit/test-aio-multithread.c
Log Message:
-----------
test-aio-multithread: do not use mb_read/mb_set for simple flags
The remaining use of mb_read/mb_set is just to force a thread to exit
eventually. It does not order two memory accesses and therefore can be
just read/set.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 355635c0187d3cc2a0cbb3381e06d61c0bf683ba
https://github.com/qemu/qemu/commit/355635c0187d3cc2a0cbb3381e06d61c0bf683ba
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M tests/unit/test-aio-multithread.c
Log Message:
-----------
test-aio-multithread: simplify test_multi_co_schedule
Instead of using qatomic_mb_{read,set} mindlessly, just use a per-coroutine
flag that requires no synchronization.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 8f593ba9c5c96b1790cc6aceb95b5b83bbac92cd
https://github.com/qemu/qemu/commit/8f593ba9c5c96b1790cc6aceb95b5b83bbac92cd
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M util/rcu.c
Log Message:
-----------
call_rcu: stop using mb_set/mb_read
Use a store-release when enqueuing a new call_rcu, and a load-acquire
when dequeuing; and read the tail after checking that node->next is
consistent, which is the standard message passing pattern and it is
clearer than mb_read/mb_set.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 20f46806b3858b92e9d1b5cf586558d62bd5a913
https://github.com/qemu/qemu/commit/20f46806b3858b92e9d1b5cf586558d62bd5a913
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M accel/tcg/tb-maint.c
Log Message:
-----------
tb-maint: do not use mb_read/mb_set
The load side can use a relaxed load, which will surely happen before
the work item is run by async_safe_run_on_cpu() or before double-checking
under mmap_lock. The store side can use an atomic RMW operation.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 2f38ff79abac8a0b779e73a025af0d0ec8911a7e
https://github.com/qemu/qemu/commit/2f38ff79abac8a0b779e73a025af0d0ec8911a7e
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M MAINTAINERS
Log Message:
-----------
MAINTAINERS: add stanza for Kconfig files
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 8cbfc530bc10a72874ab241faaba8c56e5515532
https://github.com/qemu/qemu/commit/8cbfc530bc10a72874ab241faaba8c56e5515532
Author: Thomas Huth <thuth@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M include/qemu/osdep.h
Log Message:
-----------
include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API
Commit cf60ccc330 ("cutils: Introduce bundle mechanism") abandoned
compatibility with Windows older than 8 - we should reflect this
in our _WIN32_WINNT and set it to the value that corresponds to
Windows 8.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <20230504081351.125140-1-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: cca0a000d06f897411a8af4402e5d0522bbe450b
https://github.com/qemu/qemu/commit/cca0a000d06f897411a8af4402e5d0522bbe450b
Author: Michael Roth <michael.roth@amd.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M target/i386/cpu.c
Log Message:
-----------
target/i386: allow versioned CPUs to specify new cache_info
New EPYC CPUs versions require small changes to their cache_info's.
Because current QEMU x86 CPU definition does not support versioned
cach_info, we would have to declare a new CPU type for each such case.
To avoid the dup work, add "cache_info" in X86CPUVersionDefinition",
to allow new cache_info pointers to be specified for a new CPU version.
Co-developed-by: Wei Huang <wei.huang2@amd.com>
Signed-off-by: Wei Huang <wei.huang2@amd.com>
Signed-off-by: Michael Roth <michael.roth@amd.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20230504205313.225073-2-babu.moger@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: d7c72735f618a7ee27ee109d8b1468193734606a
https://github.com/qemu/qemu/commit/d7c72735f618a7ee27ee109d8b1468193734606a
Author: Michael Roth <michael.roth@amd.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M target/i386/cpu.c
Log Message:
-----------
target/i386: Add new EPYC CPU versions with updated cache_info
Introduce new EPYC cpu versions: EPYC-v4 and EPYC-Rome-v3.
The only difference vs. older models is an updated cache_info with
the 'complex_indexing' bit unset, since this bit is not currently
defined for AMD and may cause problems should it be used for
something else in the future. Setting this bit will also cause
CPUID validation failures when running SEV-SNP guests.
Signed-off-by: Michael Roth <michael.roth@amd.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <20230504205313.225073-3-babu.moger@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: bb039a230e6a7920d71d21fa9afee2653a678c48
https://github.com/qemu/qemu/commit/bb039a230e6a7920d71d21fa9afee2653a678c48
Author: Babu Moger <babu.moger@amd.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M target/i386/cpu.c
M target/i386/cpu.h
Log Message:
-----------
target/i386: Add a couple of feature bits in 8000_0008_EBX
Add the following feature bits.
amd-psfd : Predictive Store Forwarding Disable:
PSF is a hardware-based micro-architectural optimization
designed to improve the performance of code execution by
predicting address dependencies between loads and stores.
While SSBD (Speculative Store Bypass Disable) disables both
PSF and speculative store bypass, PSFD only disables PSF.
PSFD may be desirable for the software which is concerned
with the speculative behavior of PSF but desires a smaller
performance impact than setting SSBD.
Depends on the following kernel commit:
b73a54321ad8 ("KVM: x86: Expose Predictive Store Forwarding Disable")
stibp-always-on :
Single Thread Indirect Branch Prediction mode has enhanced
performance and may be left always on.
The documentation for the features are available in the links below.
a. Processor Programming Reference (PPR) for AMD Family 19h Model 01h,
Revision B1 Processors
b. SECURITY ANALYSIS OF AMD PREDICTIVE STORE FORWARDING
Signed-off-by: Babu Moger <babu.moger@amd.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link:
https://www.amd.com/system/files/documents/security-analysis-predictive-store-forwarding.pdf
Link: https://www.amd.com/system/files/TechDocs/55898_B1_pub_0.50.zip
Message-Id: <20230504205313.225073-4-babu.moger@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: b70eec312b185197d639bff689007727e596afd1
https://github.com/qemu/qemu/commit/b70eec312b185197d639bff689007727e596afd1
Author: Babu Moger <babu.moger@amd.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M target/i386/cpu.c
M target/i386/cpu.h
Log Message:
-----------
target/i386: Add feature bits for CPUID_Fn80000021_EAX
Add the following feature bits.
no-nested-data-bp : Processor ignores nested data breakpoints.
lfence-always-serializing : LFENCE instruction is always serializing.
null-sel-cls-base : Null Selector Clears Base. When this bit is
set, a null segment load clears the segment base.
The documentation for the features are available in the links below.
a. Processor Programming Reference (PPR) for AMD Family 19h Model 01h,
Revision B1 Processors
b. AMD64 Architecture Programmer’s Manual Volumes 1–5 Publication No. Revision
40332 4.05 Date October 2022
Signed-off-by: Babu Moger <babu.moger@amd.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link: https://www.amd.com/system/files/TechDocs/55898_B1_pub_0.50.zip
Link: https://www.amd.com/system/files/TechDocs/40332_4.05.pdf
Message-Id: <20230504205313.225073-5-babu.moger@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 27f03be6f59d04bd5673ba1e1628b2b490f9a9ff
https://github.com/qemu/qemu/commit/27f03be6f59d04bd5673ba1e1628b2b490f9a9ff
Author: Babu Moger <babu.moger@amd.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M target/i386/cpu.c
Log Message:
-----------
target/i386: Add missing feature bits in EPYC-Milan model
Add the following feature bits for EPYC-Milan model and bump the version.
vaes : Vector VAES(ENC|DEC), VAES(ENC|DEC)LAST instruction support
vpclmulqdq : Vector VPCLMULQDQ instruction support
stibp-always-on : Single Thread Indirect Branch Prediction Mode has enhanced
performance and may be left Always on
amd-psfd : Predictive Store Forward Disable
no-nested-data-bp : Processor ignores nested data breakpoints
lfence-always-serializing : LFENCE instruction is always serializing
null-sel-clr-base : Null Selector Clears Base. When this bit is
set, a null segment load clears the segment base
These new features will be added in EPYC-Milan-v2. The "-cpu help" output
after the change will be.
x86 EPYC-Milan (alias configured by machine type)
x86 EPYC-Milan-v1 AMD EPYC-Milan Processor
x86 EPYC-Milan-v2 AMD EPYC-Milan Processor
The documentation for the features are available in the links below.
a. Processor Programming Reference (PPR) for AMD Family 19h Model 01h,
Revision B1 Processors
b. SECURITY ANALYSIS OF AMD PREDICTIVE STORE FORWARDING
c. AMD64 Architecture Programmer’s Manual Volumes 1–5 Publication No. Revision
40332 4.05 Date October 2022
Signed-off-by: Babu Moger <babu.moger@amd.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Link: https://www.amd.com/system/files/TechDocs/55898_B1_pub_0.50.zip
Link:
https://www.amd.com/system/files/documents/security-analysis-predictive-store-forwarding.pdf
Link: https://www.amd.com/system/files/TechDocs/40332_4.05.pdf
Message-Id: <20230504205313.225073-6-babu.moger@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 62a798d4bc2c3e767d94670776c77a7df274d7c5
https://github.com/qemu/qemu/commit/62a798d4bc2c3e767d94670776c77a7df274d7c5
Author: Babu Moger <babu.moger@amd.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M target/i386/cpu.c
M target/i386/cpu.h
Log Message:
-----------
target/i386: Add VNMI and automatic IBRS feature bits
Add the following featute bits.
vnmi: Virtual NMI (VNMI) allows the hypervisor to inject the NMI into the
guest without using Event Injection mechanism meaning not required to
track the guest NMI and intercepting the IRET.
The presence of this feature is indicated via the CPUID function
0x8000000A_EDX[25].
automatic-ibrs :
The AMD Zen4 core supports a new feature called Automatic IBRS.
It is a "set-and-forget" feature that means that, unlike e.g.,
s/w-toggled SPEC_CTRL.IBRS, h/w manages its IBRS mitigation
resources automatically across CPL transitions.
The presence of this feature is indicated via the CPUID function
0x80000021_EAX[8].
The documention for the features are available in the links below.
a. Processor Programming Reference (PPR) for AMD Family 19h Model 01h,
Revision B1 Processors
b. AMD64 Architecture Programmer’s Manual Volumes 1–5 Publication No. Revision
40332 4.05 Date October 2022
Signed-off-by: Santosh Shukla <santosh.shukla@amd.com>
Signed-off-by: Kim Phillips <kim.phillips@amd.com>
Signed-off-by: Babu Moger <babu.moger@amd.com>
Link: https://www.amd.com/system/files/TechDocs/55898_B1_pub_0.50.zip
Link: https://www.amd.com/system/files/TechDocs/40332_4.05.pdf
Message-Id: <20230504205313.225073-7-babu.moger@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 166b1741884dd4fd7090b753cd7333868457a29b
https://github.com/qemu/qemu/commit/166b1741884dd4fd7090b753cd7333868457a29b
Author: Babu Moger <babu.moger@amd.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M target/i386/cpu.c
Log Message:
-----------
target/i386: Add EPYC-Genoa model to support Zen 4 processor series
Adds the support for AMD EPYC Genoa generation processors. The model
display for the new processor will be EPYC-Genoa.
Adds the following new feature bits on top of the feature bits from
the previous generation EPYC models.
avx512f : AVX-512 Foundation instruction
avx512dq : AVX-512 Doubleword & Quadword Instruction
avx512ifma : AVX-512 Integer Fused Multiply Add instruction
avx512cd : AVX-512 Conflict Detection instruction
avx512bw : AVX-512 Byte and Word Instructions
avx512vl : AVX-512 Vector Length Extension Instructions
avx512vbmi : AVX-512 Vector Byte Manipulation Instruction
avx512_vbmi2 : AVX-512 Additional Vector Byte Manipulation Instruction
gfni : AVX-512 Galois Field New Instructions
avx512_vnni : AVX-512 Vector Neural Network Instructions
avx512_bitalg : AVX-512 Bit Algorithms, add bit algorithms Instructions
avx512_vpopcntdq: AVX-512 AVX-512 Vector Population Count Doubleword and
Quadword Instructions
avx512_bf16 : AVX-512 BFLOAT16 instructions
la57 : 57-bit virtual address support (5-level Page Tables)
vnmi : Virtual NMI (VNMI) allows the hypervisor to inject the NMI
into the guest without using Event Injection mechanism
meaning not required to track the guest NMI and intercepting
the IRET.
auto-ibrs : The AMD Zen4 core supports a new feature called Automatic
IBRS.
It is a "set-and-forget" feature that means that, unlike e.g.,
s/w-toggled SPEC_CTRL.IBRS, h/w manages its IBRS mitigation
resources automatically across CPL transitions.
Signed-off-by: Babu Moger <babu.moger@amd.com>
Message-Id: <20230504205313.225073-8-babu.moger@amd.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 23b2a3be999bd53cfac63325b8bc02a205f1fe5b
https://github.com/qemu/qemu/commit/23b2a3be999bd53cfac63325b8bc02a205f1fe5b
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M docs/devel/kconfig.rst
Log Message:
-----------
docs: clarify --without-default-devices
--without-default-devices is a specialized option that should only be used
when configs/devices/ is changed manually.
Explain the model towards which we should tend, with respect to failures
to start guests and to run "make check".
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: ef709860ea12ec59c4cd7373bd2fd7a4e50143ee
https://github.com/qemu/qemu/commit/ef709860ea12ec59c4cd7373bd2fd7a4e50143ee
Author: Paolo Bonzini <pbonzini@redhat.com>
Date: 2023-05-08 (Mon, 08 May 2023)
Changed paths:
M meson.build
Log Message:
-----------
meson: leave unnecessary modules out of the build
meson.build files choose whether to build modules based on foo.found()
expressions. If a feature is enabled (e.g. --enable-gtk), these expressions
are true even if the code is not used by any emulator, and this results
in an unexpected difference between modular and non-modular builds.
For non-modular builds, the files are not included in any binary, and
therefore the source files are never processed. For modular builds,
however, all .so files are unconditionally built by default, and therefore
a normal "make" tries to build them. However, the corresponding trace-*.h
files are absent due to this conditional:
if have_system
trace_events_subdirs += [
...
'ui',
...
]
endif
which was added to avoid wasting time running tracetool on unused trace-events
files. This causes a compilation failure; fix it by skipping module builds
entirely if (depending on the module directory) have_block or have_system
are false.
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Commit: 0c7811aeb9ba206a74008ca28f5b8ff8e7f74d04
https://github.com/qemu/qemu/commit/0c7811aeb9ba206a74008ca28f5b8ff8e7f74d04
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
Log Message:
-----------
docs/devel/qapi-code-gen: Clean up use of quotes a bit
Section "Definition documentation" uses both single and double quotes
around doc text snippets. Stick to double quotes.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-2-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: a2836b32b02a1d774f8c2504cb368c05d74ad492
https://github.com/qemu/qemu/commit/a2836b32b02a1d774f8c2504cb368c05d74ad492
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
Log Message:
-----------
docs/devel/qapi-code-gen: Turn FIXME admonitions into comments
We have two FIXME notes. These FIXMEs are for QAPI developers. They
are not useful for QAPI schema developers. They are marked up as
admonitions, which makes them look important in generated HTML.
Turn them into comments. QAPI developers will still see them (they
read and write the .rst). QAPI schema developers may still see
them (if they read the .rst instead of the generated .html), but "this
is just for QAPI developers" should be more obvious.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-3-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 5b5fe0e018891dc08bcce75f064015c42aeb46a4
https://github.com/qemu/qemu/commit/5b5fe0e018891dc08bcce75f064015c42aeb46a4
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M scripts/qapi/parser.py
Log Message:
-----------
qapi: Fix crash on stray double quote character
When the lexer chokes on a stray character, its shows the characters
until the next structural character in the error message. It uses a
regular expression to match a non-empty string of non-structural
characters. Bug: the regular expression treats '"' as structural.
When the lexer chokes on '"', the match fails, and trips
must_match()'s assertion. Fix the regular expression.
Fixes: 14c32795024c (qapi: Improve reporting of lexical errors)
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-4-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 88d357d2921669a6bbb35493ac67f4707b0144c8
https://github.com/qemu/qemu/commit/88d357d2921669a6bbb35493ac67f4707b0144c8
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M meson.build
Log Message:
-----------
meson: Fix to make QAPI generator output depend on main.py
@qapi_gen_depends is missing scripts/qapi/main.py. Fix that, and drop
a duplicate scripts/qapi/common.py.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-5-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: b71fd73cc459ce1ef545a40ff8fbce5ff242b103
https://github.com/qemu/qemu/commit/b71fd73cc459ce1ef545a40ff8fbce5ff242b103
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M qapi/block-export.json
Log Message:
-----------
Revert "qapi: BlockExportRemoveMode: move comments to TODO"
This reverts commit 97cd74f77231f3897838f8db32b659d94803e01f.
The next commit will hide TODO: sections. See there for rationale.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-6-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: f57e1d05bfaf2f41f0793280886ebf1db753794f
https://github.com/qemu/qemu/commit/f57e1d05bfaf2f41f0793280886ebf1db753794f
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
M docs/sphinx/qapidoc.py
Log Message:
-----------
sphinx/qapidoc: Do not emit TODO sections into user manuals
QAPI doc comments are for QMP users: they go into the "QEMU QMP
Reference Manual" and the "QEMU Storage Daemon QMP Reference Manual".
The doc comment TODO sections are for somebody else, namely for the
people who can do: developers. Do not emit them into the user
manuals.
This elides the following TODOs:
* SchemaInfoCommand
# TODO: @success-response (currently irrelevant, because it's QGA, not QMP)
This is a note to developers adding introspection to the guest
agent. It makes no sense to users.
* @query-hotpluggable-cpus
# TODO: Better documentation; currently there is none.
This is a reminder for developers. It doesn't help users.
* @device_add
# TODO: This command effectively bypasses QAPI completely due to its
# "additional arguments" business. It shouldn't have been added to
# the schema in this form. It should be qapified properly, or
# replaced by a properly qapified command.
Likewise.
Eliding them is an improvement.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-7-armbru@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 56266c6d1eb9a85a44e34b24eb359c6ac84887f5
https://github.com/qemu/qemu/commit/56266c6d1eb9a85a44e34b24eb359c6ac84887f5
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M qapi/migration.json
Log Message:
-----------
qapi: Tidy up a slightly awkward TODO comment
MigrateSetParameters has a TODO comment sitting right behind its doc
comment. I wrote it this way to keep it out of the manual, but that
reason is not obvious.
The previous commit (sphinx/qapidoc: Do not emit TODO sections into
user manuals) lets me move it into the doc comment as a TODO section.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-8-armbru@redhat.com>
Reviewed-by: Ani Sinha <anisinha@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 22bd6e9c152ae49de62a91f295bd9fc670806aca
https://github.com/qemu/qemu/commit/22bd6e9c152ae49de62a91f295bd9fc670806aca
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M qapi/dump.json
Log Message:
-----------
qapi/dump: Indent bulleted lists consistently
Documentation of dump-guest-memory contains two bulleted lists. The
first one is indented, the second one isn't. Delete the first one's
indentation for a more consistent look.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-9-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 5962635561d3f6ce2740b2f2fa110ae796184365
https://github.com/qemu/qemu/commit/5962635561d3f6ce2740b2f2fa110ae796184365
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M tests/qapi-schema/doc-good.json
M tests/qapi-schema/doc-good.out
Log Message:
-----------
tests/qapi-schema/doc-good: Improve a comment
The QAPI generator doesn't reject undocumented members and
features (yet). doc-good.json covers this, with clear "is
undocumented" notes to signal intent.
Except for @Variant1 member @var1, where it's "(but no @var: line)".
Less clear. Replace by "@var1 is undocumented".
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-10-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: a87a9b4d4fc4dcfa2925b1b90474f0ec69d59edf
https://github.com/qemu/qemu/commit/a87a9b4d4fc4dcfa2925b1b90474f0ec69d59edf
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M tests/qapi-schema/doc-good.json
M tests/qapi-schema/doc-good.out
Log Message:
-----------
tests/qapi-schema/doc-good: Improve argument description tests
Improve the comments to better describe what they test.
Cover argument description starting on a new line indented. This
style isn't documented in docs/devel/qapi-code-gen.rst. qapi-gen.py
accepts it, but messes up indentation: it's stripped from the first
line, not subsequent ones. The next commit will fix this.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-11-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 9b2c6746d30a44d222e9124faee59eb05703b6ae
https://github.com/qemu/qemu/commit/9b2c6746d30a44d222e9124faee59eb05703b6ae
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M scripts/qapi/parser.py
M tests/qapi-schema/doc-good.out
Log Message:
-----------
qapi: Fix argument description indentation stripping
When an argument's description starts on the line after the "#arg: "
line, indentation is stripped only from the description's first line,
as demonstrated by the previous commit. Moreover, subsequent lines
with less indentation are not rejected.
Make the first line's indentation the expected indentation for the
remainder of the description. This fixes indentation stripping, and
also requires at least that much indentation.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-12-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: 932e6648e8e57e5138bbb0072a7d29882910d453
https://github.com/qemu/qemu/commit/932e6648e8e57e5138bbb0072a7d29882910d453
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M scripts/qapi/parser.py
Log Message:
-----------
qapi: Rewrite parsing of doc comment section symbols and tags
To recognize a line starting with a section symbol and or tag, we
first split it at the first space, then examine the part left of the
space. We can just as well examine the unsplit line, so do that.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-13-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: fb8a2c7d935dc33ac7f1830cc52150f651e6cd08
https://github.com/qemu/qemu/commit/fb8a2c7d935dc33ac7f1830cc52150f651e6cd08
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
M scripts/qapi/parser.py
M tests/qapi-schema/doc-bad-indent.err
M tests/qapi-schema/doc-bad-indent.json
M tests/qapi-schema/doc-good.json
M tests/qapi-schema/doc-good.out
Log Message:
-----------
qapi: Relax doc string @name: description indentation rules
The QAPI schema doc comment language provides special syntax for
command and event arguments, struct and union members, alternate
branches, enumeration values, and features: descriptions starting with
"@name:".
By convention, we format them like this:
# @name: Lorem ipsum dolor sit amet, consectetur adipiscing elit,
# sed do eiusmod tempor incididunt ut labore et dolore
# magna aliqua.
Okay for names as short as "name", but we have much longer ones. Their
description gets squeezed against the right margin, like this:
# @dirty-sync-missed-zero-copy: Number of times dirty RAM synchronization
could
# not avoid copying dirty pages. This is
between
# 0 and @dirty-sync-count * @multifd-channels.
# (since 7.1)
The description text is effectively just 50 characters wide. Easy
enough to read, but can be cumbersome to write.
The awkward squeeze against the right margin makes people go beyond it,
which produces two undesirables: arguments about style, and descriptions
that are unnecessarily hard to read, like this one:
# @postcopy-vcpu-blocktime: list of the postcopy blocktime per vCPU. This
is
# only present when the postcopy-blocktime
migration capability
# is enabled. (Since 3.0)
We could instead format it like
# @postcopy-vcpu-blocktime:
# list of the postcopy blocktime per vCPU. This is only present
# when the postcopy-blocktime migration capability is
# enabled. (Since 3.0)
or, since the commit before previous, like
# @postcopy-vcpu-blocktime:
# list of the postcopy blocktime per vCPU. This is only present
# when the postcopy-blocktime migration capability is
# enabled. (Since 3.0)
However, I'd rather have
# @postcopy-vcpu-blocktime: list of the postcopy blocktime per vCPU.
# This is only present when the postcopy-blocktime migration
# capability is enabled. (Since 3.0)
because this is how rST field and option lists work.
To get this, we need to let the first non-blank line after the
"@name:" line determine expected indentation.
This fills up the indentation pitfall mentioned in
docs/devel/qapi-code-gen.rst. A related pitfall still exists. Update
the text to show it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-14-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: fa6940d1b0fb6a3320e75469e42b2b64643b339d
https://github.com/qemu/qemu/commit/fa6940d1b0fb6a3320e75469e42b2b64643b339d
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M scripts/qapi/parser.py
Log Message:
-----------
qapi: Section parameter @indent is no longer used, drop
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-15-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: abdf85d3bca25d421343928524126995081f8fb9
https://github.com/qemu/qemu/commit/abdf85d3bca25d421343928524126995081f8fb9
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
Log Message:
-----------
docs/devel/qapi-code-gen: Update doc comment conventions
The commit before previous relaxed the indentation rules to let us
improve the doc comment conventions. This commit changes the written
conventions. The next commits will update QAPI schemas to conform to
them.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-16-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: da0bf856ed6b0b69fde2964fd353771579e63785
https://github.com/qemu/qemu/commit/da0bf856ed6b0b69fde2964fd353771579e63785
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M qga/qapi-schema.json
Log Message:
-----------
qga/qapi-schema: Reformat doc comments to conform to current conventions
Change
# @name: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed
# do eiusmod tempor incididunt ut labore et dolore magna aliqua.
to
# @name: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed
# do eiusmod tempor incididunt ut labore et dolore magna aliqua.
See recent commit "qapi: Relax doc string @name: description
indentation rules" for rationale.
Reflow paragraphs to 70 columns width, and consistently use two spaces
to separate sentences.
To check the generated documentation does not change, I compared the
generated HTML before and after this commit with "wdiff -3". Finds no
differences. Comparing with diff is not useful, as the reflown
paragraphs are visible there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-17-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Commit: ddd37ae995acacfd858d2ee090c3fa61e33b986b
https://github.com/qemu/qemu/commit/ddd37ae995acacfd858d2ee090c3fa61e33b986b
Author: Markus Armbruster <armbru@redhat.com>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M qapi/acpi.json
M qapi/audio.json
M qapi/authz.json
M qapi/block-core.json
M qapi/block-export.json
M qapi/block.json
M qapi/char.json
M qapi/common.json
M qapi/compat.json
M qapi/control.json
M qapi/crypto.json
M qapi/cryptodev.json
M qapi/cxl.json
M qapi/dump.json
M qapi/error.json
M qapi/introspect.json
M qapi/job.json
M qapi/machine-target.json
M qapi/machine.json
M qapi/migration.json
M qapi/misc-target.json
M qapi/misc.json
M qapi/net.json
M qapi/pci.json
M qapi/qapi-schema.json
M qapi/qdev.json
M qapi/qom.json
M qapi/rdma.json
M qapi/replay.json
M qapi/rocker.json
M qapi/run-state.json
M qapi/sockets.json
M qapi/stats.json
M qapi/tpm.json
M qapi/trace.json
M qapi/transaction.json
M qapi/ui.json
M qapi/virtio.json
M qapi/yank.json
Log Message:
-----------
qapi: Reformat doc comments to conform to current conventions
Change
# @name: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed
# do eiusmod tempor incididunt ut labore et dolore magna aliqua.
to
# @name: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed
# do eiusmod tempor incididunt ut labore et dolore magna aliqua.
See recent commit "qapi: Relax doc string @name: description
indentation rules" for rationale.
Reflow paragraphs to 70 columns width, and consistently use two spaces
to separate sentences.
To check the generated documentation does not change, I compared the
generated HTML before and after this commit with "wdiff -3". Finds no
differences. Comparing with diff is not useful, as the reflown
paragraphs are visible there.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20230428105429.1687850-18-armbru@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Acked-by: Lukas Straub <lukasstraub2@web.de>
[Straightforward conflicts in qapi/audio.json qapi/misc-target.json
qapi/run-state.json resolved]
Commit: ef73c6e8601a0cee5156e56b381998ed3f9f53d1
https://github.com/qemu/qemu/commit/ef73c6e8601a0cee5156e56b381998ed3f9f53d1
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M docs/devel/qapi-code-gen.rst
M docs/sphinx/qapidoc.py
M meson.build
M qapi/acpi.json
M qapi/audio.json
M qapi/authz.json
M qapi/block-core.json
M qapi/block-export.json
M qapi/block.json
M qapi/char.json
M qapi/common.json
M qapi/compat.json
M qapi/control.json
M qapi/crypto.json
M qapi/cryptodev.json
M qapi/cxl.json
M qapi/dump.json
M qapi/error.json
M qapi/introspect.json
M qapi/job.json
M qapi/machine-target.json
M qapi/machine.json
M qapi/migration.json
M qapi/misc-target.json
M qapi/misc.json
M qapi/net.json
M qapi/pci.json
M qapi/qapi-schema.json
M qapi/qdev.json
M qapi/qom.json
M qapi/rdma.json
M qapi/replay.json
M qapi/rocker.json
M qapi/run-state.json
M qapi/sockets.json
M qapi/stats.json
M qapi/tpm.json
M qapi/trace.json
M qapi/transaction.json
M qapi/ui.json
M qapi/virtio.json
M qapi/yank.json
M qga/qapi-schema.json
M scripts/qapi/parser.py
M tests/qapi-schema/doc-bad-indent.err
M tests/qapi-schema/doc-bad-indent.json
M tests/qapi-schema/doc-good.json
M tests/qapi-schema/doc-good.out
Log Message:
-----------
Merge tag 'pull-qapi-2023-05-09' of https://repo.or.cz/qemu/armbru into
staging
QAPI patches patches for 2023-05-09
# -----BEGIN PGP SIGNATURE-----
#
# iQJGBAABCAAwFiEENUvIs9frKmtoZ05fOHC0AOuRhlMFAmRZ/TsSHGFybWJydUBy
# ZWRoYXQuY29tAAoJEDhwtADrkYZTPJEP/j1Mo6zkMxXcrLxu6zDiUELbtMlJtVDz
# i5/o7+IlGiyXqWkAVER8jCaaWxS5HSX3aLyf1yGH/xZazEBOvGiaIwNka87edwpD
# zehBFOHV9458PaOMOPhL1JpJi0jF37XQTAZ1fp4rSGHBOnXk52Z7BXrfBrrNB3AP
# NGr2yyNoDUrwIPaKeoY4EdP+Ie5l+mGxqhtgnHXJEYizkodqqhRvqN0k5RdR3+mi
# RNftP5H+qff+tEXy8y4n8LTni3Csp64bS0SYkaFH4wPegYP63SomqWbpj+CTIRyh
# B3o++y8NcRvEbRcekJzlTNGvHv5G+AlTxpaQvqdRIJJhurWIsPq6LQ7H7mIXX/e0
# TudM+TzfdwQXLoKxzxdPZjeTxaHz38LTm6Lbdc18fGrhNmSmLQc3EUllJia2nlC5
# Qb2GkCwrU8fXYWd1yzB0ovgX1Xt1DuYdAWhHMI2Bjb7ER7yNTT//uV0Lo6pjG9JK
# O32cB3mXrS9yr0JqGEvxJJENAeGuZb9EuTjIaBRYqtV9apIOZ3JsiotNcv3xv/9+
# mBqxpJR5yxHxu5YOMN2Y2zfMQHl8GsfOseQp+QvDb+KwsV728fiMXS9Efnsl9SHm
# tDAsOt3DrScio2B0eEHQWW395Bc8LO4ZetUth5Xs9GH5aX6kW4zAx9GVR7FZJ2Zi
# 8YzC9Y82UbLW
# =lYsx
# -----END PGP SIGNATURE-----
# gpg: Signature made Tue 09 May 2023 08:58:51 AM BST
# gpg: using RSA key 354BC8B3D7EB2A6B68674E5F3870B400EB918653
# gpg: issuer "armbru@redhat.com"
# gpg: Good signature from "Markus Armbruster <armbru@redhat.com>" [undefined]
# gpg: aka "Markus Armbruster <armbru@pond.sub.org>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 354B C8B3 D7EB 2A6B 6867 4E5F 3870 B400 EB91 8653
* tag 'pull-qapi-2023-05-09' of https://repo.or.cz/qemu/armbru:
qapi: Reformat doc comments to conform to current conventions
qga/qapi-schema: Reformat doc comments to conform to current conventions
docs/devel/qapi-code-gen: Update doc comment conventions
qapi: Section parameter @indent is no longer used, drop
qapi: Relax doc string @name: description indentation rules
qapi: Rewrite parsing of doc comment section symbols and tags
qapi: Fix argument description indentation stripping
tests/qapi-schema/doc-good: Improve argument description tests
tests/qapi-schema/doc-good: Improve a comment
qapi/dump: Indent bulleted lists consistently
qapi: Tidy up a slightly awkward TODO comment
sphinx/qapidoc: Do not emit TODO sections into user manuals
Revert "qapi: BlockExportRemoveMode: move comments to TODO"
meson: Fix to make QAPI generator output depend on main.py
qapi: Fix crash on stray double quote character
docs/devel/qapi-code-gen: Turn FIXME admonitions into comments
docs/devel/qapi-code-gen: Clean up use of quotes a bit
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Commit: 77596bc48aac7fbcb8d16f49d6fdc834042f8d1f
https://github.com/qemu/qemu/commit/77596bc48aac7fbcb8d16f49d6fdc834042f8d1f
Author: Richard Henderson <richard.henderson@linaro.org>
Date: 2023-05-09 (Tue, 09 May 2023)
Changed paths:
M MAINTAINERS
M accel/tcg/tb-maint.c
M docs/devel/kconfig.rst
M include/qemu/osdep.h
M include/qemu/rcu.h
M meson.build
M target/i386/cpu.c
M target/i386/cpu.h
M tests/unit/test-aio-multithread.c
M util/rcu.c
Log Message:
-----------
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging
* target/i386: improved EPYC models
* more removal of mb_read/mb_set
* bump _WIN32_WINNT to the Windows 8 API
* fix for modular builds with --disable-system
# -----BEGIN PGP SIGNATURE-----
#
# iQFIBAABCAAyFiEE8TM4V0tmI4mGbHaCv/vSX3jHroMFAmRZK7wUHHBib256aW5p
# QHJlZGhhdC5jb20ACgkQv/vSX3jHroObngf8D6A5l1QQAnImRrZAny6HZV/9xseD
# 9QhkUW3fxXlUhb8tXomv2BlT8h9GzLIN6aWvcCotT+xK3kAX7mRcYKgPMr9CYL7y
# vev/hh+B6RY1CJ/xPT09/BMVjkj50AL0O/OuWMhcQ5nCO7F2sdMjMrsYqqeZcjYf
# zx9RTX7gVGt+wWFHxgCgdfL0kfgzexK55YuZU0vLzcA+pYsZWoEfW+fKBIf4rzDV
# r9M6mDBUkHBQ0rIVC3QFloAXnYb1JrpeqqL2i2qwhAkLz8LyGqk3lZF20hE/04im
# XZcZjWO5pxAxIEPeTken+2x1n8tn2BLkMtvwJdV5TpvICCFRtPZlbH79qw==
# =rXLN
# -----END PGP SIGNATURE-----
# gpg: Signature made Mon 08 May 2023 06:05:00 PM BST
# gpg: using RSA key F13338574B662389866C7682BFFBD25F78C7AE83
# gpg: issuer "pbonzini@redhat.com"
# gpg: Good signature from "Paolo Bonzini <bonzini@gnu.org>" [undefined]
# gpg: aka "Paolo Bonzini <pbonzini@redhat.com>" [undefined]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg: There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 46F5 9FBD 57D6 12E7 BFD4 E2F7 7E15 100C CD36 69B1
# Subkey fingerprint: F133 3857 4B66 2389 866C 7682 BFFB D25F 78C7 AE83
* tag 'for-upstream' of https://gitlab.com/bonzini/qemu:
meson: leave unnecessary modules out of the build
docs: clarify --without-default-devices
target/i386: Add EPYC-Genoa model to support Zen 4 processor series
target/i386: Add VNMI and automatic IBRS feature bits
target/i386: Add missing feature bits in EPYC-Milan model
target/i386: Add feature bits for CPUID_Fn80000021_EAX
target/i386: Add a couple of feature bits in 8000_0008_EBX
target/i386: Add new EPYC CPU versions with updated cache_info
target/i386: allow versioned CPUs to specify new cache_info
include/qemu/osdep.h: Bump _WIN32_WINNT to the Windows 8 API
MAINTAINERS: add stanza for Kconfig files
tb-maint: do not use mb_read/mb_set
call_rcu: stop using mb_set/mb_read
test-aio-multithread: simplify test_multi_co_schedule
test-aio-multithread: do not use mb_read/mb_set for simple flags
rcu: remove qatomic_mb_set, expand comments
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Compare: https://github.com/qemu/qemu/compare/271477b59e72...77596bc48aac
- [Qemu-commits] [qemu/qemu] 6e288b: rcu: remove qatomic_mb_set, expand comments,
Richard Henderson <=