[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] PATCH: block-vvfat.c: fix parse_long_name
From: |
Johannes Schindelin |
Subject: |
Re: [Qemu-devel] PATCH: block-vvfat.c: fix parse_long_name |
Date: |
Wed, 2 Jul 2008 18:10:51 +0100 (BST) |
User-agent: |
Alpine 1.00 (DEB 882 2007-12-20) |
Hi,
On Wed, 2 Jul 2008, Tristan Gingold wrote:
> I am ready to submit patches just to add comments in block-vvfat.c. Do
> you think it is a good idea ?
Yes.
> >- unsigned char name[1024];
> >+ /*
> >+ * Since the sequence number is at most 0x3f, and the file length is
> >+ * at most 13 times the sequence number, the maximal file length is
> >+ * 0x3f * 13 bytes.
> >+ */
> >+ unsigned char name[0x3f * 13 + 1];
>
> s/file length/filename length/ ?
Yes.
Ciao,
Dscho