[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmis

From: Blue Swirl
Subject: Re: [Qemu-devel] [RFC, PATCH] Add -Wstrict-prototypes, maybe later -Wmissing-prototypes
Date: Mon, 11 Aug 2008 21:52:11 +0300

On 8/11/08, Anthony Liguori <address@hidden> wrote:
> Avi Kivity wrote:
> >
> > You lose the switch(nb_args) in monitor_handle_command() so it comes out
> even.  You don't need to cast anything -- though you do need to change all
> the callbacks to accept an argument array.
> >
>  And to either explicitly cast each argument or explicitly parse each
> argument.  It touches quite a bit of places in the code and makes the
> callbacks quite a bit more complicated.
>  Using a void * is a one line change and works on all modern systems.  Seems
> like a winner to me :-)

I vote for this. The other solutions do not improve type safety
(except for union) and they are more complex.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]