[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tosa: basic lcd support
From: |
andrzej zaborowski |
Subject: |
Re: [Qemu-devel] [PATCH] tosa: basic lcd support |
Date: |
Tue, 4 Nov 2008 10:14:33 +0100 |
2008/11/2 Dmitry Baryshkov <address@hidden>:
> On Sun, Nov 02, 2008 at 05:09:04PM +0100, andrzej zaborowski wrote:
>> 2008/11/2 Dmitry Baryshkov <address@hidden>:
>> > +static void tosa_tg_init(struct pxa2xx_state_s *cpu)
>> > +{
>> > + struct i2c_bus *bus = pxa2xx_i2c_bus(cpu->i2c[0]);
>> > + struct i2c_slave *dac = i2c_slave_init(bus, 0, sizeof(struct
>> > tosa_dac_i2c));
>> > + dac->send = tosa_dac_send;
>> > + dac->event = tosa_dac_event;
>>
>> You should set also .recv to not leave the kernel a possibility to
>> crash qemu. Other than this, looks okay, but does this code help
>> emulation in anyway? I suppose the kernel wants to see some i2c
>> device present?
>
> The kernel expects to have the DAC in place. Otherwise I see barfs from
> it. So adding such simple i2c client is just a matter of preference.
> Anyway, please check this patch with .recv callback set:
Right, it expects a DAC. What I mean is that this implementation can
equally well be a i2c framebuffer or a flux capacitor ;) But I assume
you've tested that this already made the kernel happy.
Regards
- [Qemu-devel] [PATCH] tosa: provide correct IRQ to tc6393xb init, (continued)
- [Qemu-devel] [PATCH] tosa: provide correct IRQ to tc6393xb init, Dmitry Baryshkov, 2008/11/02
- [Qemu-devel] [PATCH] tosa: disable pxafb as it's not used on tosa., Dmitry Baryshkov, 2008/11/02
- [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry Baryshkov, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, andrzej zaborowski, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry Baryshkov, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry Baryshkov, 2008/11/02
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, andrzej zaborowski, 2008/11/03
- Re: [Qemu-devel] [PATCH] tc6393xb: non-accelerated FB support, Dmitry, 2008/11/03
- Re: [Qemu-devel] [PATCH] tosa: basic lcd support, andrzej zaborowski, 2008/11/02
- Re: [Qemu-devel] [PATCH] tosa: basic lcd support, Dmitry Baryshkov, 2008/11/02
- Re: [Qemu-devel] [PATCH] tosa: basic lcd support,
andrzej zaborowski <=
[Qemu-devel] Re: [PATCH] scoop: GPRR reports the state of GPIO lines, Dmitry Baryshkov, 2008/11/02