|
From: | Avi Kivity |
Subject: | Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches |
Date: | Mon, 20 Apr 2009 11:32:50 +0300 |
User-agent: | Thunderbird 2.0.0.21 (X11/20090320) |
Blue Swirl wrote:
> IIRC, one of the requirements is to use your real name :)I can't find such a requirement :)
From [1]:
<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=f309d3c6221c3699a0c0b97fbe689faed09e4d2f;hb=HEAD#l320>then you just add a line saying<http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=f309d3c6221c3699a0c0b97fbe689faed09e4d2f;hb=HEAD#l321> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=f309d3c6221c3699a0c0b97fbe689faed09e4d2f;hb=HEAD#l322> Signed-off-by: Random J Developer <address@hidden><http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=f309d3c6221c3699a0c0b97fbe689faed09e4d2f;hb=HEAD#l323> <http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=f309d3c6221c3699a0c0b97fbe689faed09e4d2f;hb=HEAD#l324> using your real name (sorry, no pseudonyms or anonymous contributions.)
If the patch is attached (and not inlined) it should be marked as text/plain content type.Added.
Your own message has --001485f87bbc990faa0467eb577c Content-Type: plain/text; name="submitting_patches.diff" Content-Disposition: attachment; filename="submitting_patches.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ftpzesul So my client won't display it inline :) A local misconfiguration, or is plain/text legal?
Suggest instead: patches should state which branch they are based on, and should be based on a recent version of the branch.I'd suppose most of the patches are for the development branch, so one of the subject tags could be "STABLE" indicating stable branch. Without it dev branch is assumed.
Right.[1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=f309d3c6221c3699a0c0b97fbe689faed09e4d2f;hb=HEAD
-- error compiling committee.c: too many arguments to function
[Prev in Thread] | Current Thread | [Next in Thread] |