[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH, RFC] Add file describing rules for submitti

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH, RFC] Add file describing rules for submitting patches
Date: Mon, 20 Apr 2009 09:23:46 -0500
User-agent: Thunderbird (X11/20090320)

M. Warner Losh wrote:
In message: <address@hidden>
            Jan Kiszka <address@hidden> writes:
: Blue Swirl wrote:
: > Hi,
: > : > I gathered a few common complaints about patch submission, hopefully
: > not too much affected by my consumption of small amounts of various
: > alcoholic substances.
: : Don't drink and patch. Oh, wait, this was: "Don't drink and derive!" So
: this is probably ok.
: : > : > Comments, objections? : : SP3.2: If you only attach, pleeeease don't use base64 encoding etc. And
: there should be no maintainer exception...

How can you attach a patch with MIME and not do that?

If you tolerate MIME, you have to accept different encoding types (including base64). Right now, just accepting text/plain and text/x-diff seems to work well enough. The most common failure for my scripts wrt attachments is with mailers that do application/binary or some similarly opaque mime type. What's particularly bad are mailers that send a plain text descriptions, HTML descriptions, and then the patch. This last two categories are too difficult to handle correctly in scripts so that's where I want to bounce. It's not a huge problem though. It only happens in < %1 of patches.


Anthony Liguori


reply via email to

[Prev in Thread] Current Thread [Next in Thread]