[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [7234] Use a more natural order

From: Glauber Costa
Subject: Re: [Qemu-devel] [7234] Use a more natural order
Date: Thu, 23 Apr 2009 16:15:59 -0300

On Thu, Apr 23, 2009 at 4:10 PM, Lennart Sorensen
<address@hidden> wrote:
> On Thu, Apr 23, 2009 at 10:01:43PM +0300, Blue Swirl wrote:
>> True, but it's not the style that is used here. You are of course free
>> to argue for using this version and even submit patches.
> I didn't check if it is covered by the codestyle or not for qemu.
> If your patch comment had said "Fix to follow code style" rather than
> "make natural order" I wouldn't have said anything.  Natural order in
> this case is a bad reason for the change.  Following code style is a
> good reason (even if the code style may then be questionable).
> If the code style doesn't cover it at all, I would say the change is
> horrible and shouldn't be done at all.  The change even caused a compile
> failure briefly (and hence breaks git bisect) by being commited completely
> untested I suspect.  If it didn't cause a compile failure it at least
> should have caused a serious warning.

Note that this could be avoided by not commiting the code in the first place,
but rather, sending it to the mailing list. Everybody should be sending code
to the mailing list, even maintainers.

Anthony is already doing that, and it greatly reduces the probability of getting
a broken bisect for broken patches.

Glauber  Costa.
"Free as in Freedom"

"The less confident you are, the more serious you have to act."

reply via email to

[Prev in Thread] Current Thread [Next in Thread]