[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup()
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() |
Date: |
Thu, 30 Apr 2009 20:16:45 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Anthony Liguori wrote:
> Jan Kiszka wrote:
>> That would only allow one such pair per VM.
>>
>
> id basically becomes another type of vlan id. To have multiple nics,
> you do:
>
> -net tap,vlan=off,id=1234 -net nic,model=virtio,vlan=off,id=1234
> -net tap,vlan=off,id=4321 -net nic,model=virtio,vlan=off,id=4321
>
> And this goes back to the notion of having all device
> front-ends/back-ends have some sort of identifier to associate one to
> the other.
>
>> Why not keeping all the existing infrastructure, just locking a vlan
>> against becoming more than a point-to-point link once some conflicting
>> optimization was applied? That should be easy to implement and to
>> explain to the user.
>>
>
> I think you're suggesting the same thing as me, except you are saying
> make vlan=off implicit, and use vlan=XXX instead of id=XXX.
Look like. :)
>
> We can still make vlan=off implicit, and default id=0, so that -net tap
> net nic,model=virtio does the right thing. However, if a user
> explicitly says -net tap,vlan=1 -net nic,model=virtio,vlan=1, it behaves
> like it used to.
That's my point. And if he tries "-net tap -net nic,model=virtio -net
nic", qemu will fall back to bus-like vlan. And if he tries do add the
third nic during runtime, there will be a descriptive error message.
That should be most elegant while not blocking optimizations (of the
common case).
Jan
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), (continued)
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Jan Kiszka, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Avi Kivity, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Jan Kiszka, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Avi Kivity, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Blue Swirl, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Jan Kiszka, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Blue Swirl, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(),
Jan Kiszka <=
- Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Markus Armbruster, 2009/04/29
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Mark McLoughlin, 2009/04/16
- [Qemu-devel] Re: [PATCH 5/9] Remove some useless malloc() checking, Jan Kiszka, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, Christoph Hellwig, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, Mark McLoughlin, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, Christoph Hellwig, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, François Revol, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, M. Warner Losh, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, M. Warner Losh, 2009/04/15
Re: [Qemu-devel] [PATCH 1/9] Remove stray GSO code from virtio_net, Anthony Liguori, 2009/04/17