[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup()
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup() |
Date: |
Thu, 30 Apr 2009 20:20:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Blue Swirl wrote:
> On 4/30/09, Anthony Liguori <address@hidden> wrote:
>> Jan Kiszka wrote:
>>> Why not keeping all the existing infrastructure, just locking a vlan
>>> against becoming more than a point-to-point link once some conflicting
>>> optimization was applied? That should be easy to implement and to
>>> explain to the user.
>>>
>>>
>> I think you're suggesting the same thing as me, except you are saying make
>> vlan=off implicit, and use vlan=XXX instead of id=XXX.
>>
>> We can still make vlan=off implicit, and default id=0, so that -net tap net
>> nic,model=virtio does the right thing. However, if a user explicitly says
>> -net tap,vlan=1 -net nic,model=virtio,vlan=1, it behaves like it used to.
>
> Nice, though if there are two vlans, one specified without explicit ID
> and the other with ID=1, the performance will be different.
Uh, the second case should rather behave like the first. Only if the
number vlan clients grows beyond 2, point-to-point optimizations should
be disabled (unless already enabled, then adding clients should be denied).
Jan
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), (continued)
- Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Blue Swirl, 2009/04/30
- Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Jan Kiszka, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Avi Kivity, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Jan Kiszka, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Avi Kivity, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Blue Swirl, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(),
Jan Kiszka <=
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Anthony Liguori, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Blue Swirl, 2009/04/30
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Jan Kiszka, 2009/04/30
- Re: [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Markus Armbruster, 2009/04/29
- [Qemu-devel] Re: [PATCH 9/9] Introduce VLANClientState::cleanup(), Mark McLoughlin, 2009/04/16
- [Qemu-devel] Re: [PATCH 5/9] Remove some useless malloc() checking, Jan Kiszka, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, Christoph Hellwig, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, Mark McLoughlin, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, Christoph Hellwig, 2009/04/15
- Re: [Qemu-devel] [PATCH 2/9] struct iovec is now universally available, François Revol, 2009/04/15