Re: [Qemu-devel] [PATCH 1/4] qdev/isa: add isa bus support to qdev.

[Filip Navara]

2009/7/15 Gerd Hoffmann <address@hidden>:
> +static struct BusInfo isa_bus_info = {
> +    .name  = "ISA",
> +    .size  = sizeof(ISABus),
> +    .props = (Property[]) {
> +        {
> +            .name   = "iobase",
> +            .info   = &qdev_prop_hex32,
> +            .offset = offsetof(ISADevice, iobase[0]),
> +            .defval = (uint32_t[]) { -1 },
> +        },{
> +            .name   = "iobase2",
> +            .info   = &qdev_prop_hex32,
> +            .offset = offsetof(ISADevice, iobase[1]),
> +            .defval = (uint32_t[]) { -1 },
> +        },
> +        {/* end of list */}
> +    }
> +};

Why exactly two IO bases? That sounds like bad design to me. IMHO it
should be handled more like sysbus_init_mmio (or sysbus_init_mmio_cb)
and sysbus_mmio_map and the number of IO bases should be virtually
unlimited (something like QDEV_MAX_MMIO is acceptable).

Best regards,
Filip Navara