[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1/8] ide: add IDEBus struct, cleanups
From: |
Juan Quintela |
Subject: |
[Qemu-devel] Re: [PATCH 1/8] ide: add IDEBus struct, cleanups |
Date: |
Wed, 19 Aug 2009 11:49:39 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Reviewed-by: Juan Quintela <address@hidden>
Reply-to: address@hidden
Gerd Hoffmann <address@hidden> wrote:
>
> switch(addr) {
> case 0:
> break;
> case 1:
> - ide_clear_hob(ide_if);
> + ide_clear_hob(bus);
> /* NOTE: data is written to the two drives */
> - ide_if[0].hob_feature = ide_if[0].feature;
> - ide_if[1].hob_feature = ide_if[1].feature;
> - ide_if[0].feature = val;
> - ide_if[1].feature = val;
> + bus->ifs[0].hob_feature = bus->ifs[0].feature;
> + bus->ifs[1].hob_feature = bus->ifs[1].feature;
> + bus->ifs[0].feature = val;
> + bus->ifs[1].feature = val;
> break;
Once that you are here, can you fix the indentantion, please?
(rest of this case have this strange indentantion)
That is a nitpit, and already exist in previous code.
- [Qemu-devel] [PATCH 0/8] ide: cleanup and splitting., Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 3/8] ide: add save/restore support for isa, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 2/8] ide: split away ide-isa.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 1/8] ide: add IDEBus struct, cleanups, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] Re: [PATCH 1/8] ide: add IDEBus struct, cleanups,
Juan Quintela <=
- [Qemu-devel] [PATCH 4/8] ide: split away ide-pci.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 7/8] ide: add save/restore support for mmio, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 6/8] ide: split away ide-mmio.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 8/8] ide: split away ide-microdrive.c, Gerd Hoffmann, 2009/08/18
- [Qemu-devel] [PATCH 5/8] ide: split away ide-macio.c, Gerd Hoffmann, 2009/08/18
- Re: [Qemu-devel] [PATCH 0/8] ide: cleanup and splitting., Avi Kivity, 2009/08/18