[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386
[Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code
Mon, 9 Nov 2009 23:21:49 +0100
On 09.11.2009, at 23:12, Jan Kiszka wrote:
Hollis Blanchard wrote:
Unbreaks PowerPC and S390 KVM builds.
What breaks precisely?
Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be
shared with ia64 - one day. We could still move things back then, but
maybe we can handle the build issues already in place, specifically as
qemu-kvm is carrying this in generic code since ages.
The "generic" code tries to access env->mp_state which doesn't exist
in PPC's env because it's only defined in the X86 env.
I honestly don't care where to move things. And I don't think anyone
else should. Either move it to CPU_COMMON if you think it's generic or
move the code to the platform specific part.
We've been going through this at least 2 times in previous threads.
But qemu HEAD has been broken for PPC kvm since MP states got
introduced and it's no fun talking against walls on this.