[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386
[Qemu-devel] Re: [PATCH 1 of 2] kvm: Move KVM mp_state accessors to i386-specific code
Mon, 09 Nov 2009 17:22:25 -0600
Thunderbird 220.127.116.11 (X11/20090825)
Jan Kiszka wrote:
Hollis Blanchard wrote:
Unbreaks PowerPC and S390 KVM builds.
What breaks precisely?
Note that KVM_GET/SET_MP_STATE are generic IOCTLs and supposed to be
shared with ia64 - one day. We could still move things back then, but
maybe we can handle the build issues already in place, specifically as
qemu-kvm is carrying this in generic code since ages.
mp_state is pretty specific to the in-kernel apic. ia64 may share
because it shares an interrupt controller but that does not make it
generic. That just makes two architectures have a common field.
I don't think there's anything wrong with kvm exposing this as a common
ioctl but from a qemu perspective, it makes no sense as a common cpu
field. It only makes sense when using kvm and when using an in-kernel
apic. That's very architecture specific from an qemu perspective.