[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB t

From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer
Date: Tue, 10 Nov 2009 16:33:34 +0100

On 10.11.2009, at 16:14, Scott Tsai wrote:

+    s->temperature++;

You're going to overheat very quickly.
Apart from making the driver work, is this actually useful?

I wanted the temperature to change with time to give a sense of
"something is happening" ^_^

The main user I had in mind was someone new to USB and Linux driver development
following gregkh's driver tutorial:
My thinking was that if the temperature never changes, all the USB
packets generated in the 'read_int_callback"
part of the driver would seem like a waste of effort.

How about having a monitor command to change the temperature, leveraging a "common interface"? That way in the future real host temperature measurements could maybe get forwarded there too. At least for battery I've had several people ask already if it's possible to read the host battery status (incl. AC status) from inside the VM.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]