[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into gene

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH 09/15] scsi: move scsi request parsing into generic code.
Date: Tue, 17 Nov 2009 13:51:29 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091014 Fedora/3.0-2.8.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 11/17/09 13:27, Paul Brook wrote:
On Tuesday 17 November 2009, Christoph Hellwig wrote:
The subject is a bit confusing - it's not the full request parsing but
just some helpers.

This is a good example of a patch with an insufficient commit message.
Given the way GIT treats the first line of the commit mesaage, my advice is to
make both the subject and the body of the commit message independent.

On a more technical note, why aren't you also using this function in scsi-
disc.c? Surely that's the whole point of moving it into common code.

Same as with the command move: next patch series will rework scsi-disk to put the new fields and functions into use.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]