[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH 0/3] qcow2: Rewrite alloc_refcount_block
Date: Sat, 20 Feb 2010 11:02:13 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20091209 Fedora/3.0-4.fc12 Lightning/1.0pre Thunderbird/3.0

On 02/19/2010 07:49 PM, Juan Quintela wrote:
Anthony Liguori<address@hidden>  wrote:
On 02/15/2010 10:19 AM, Kevin Wolf wrote:
The current implementation of alloc_refcount_block and grow_refcount_table has
fundamental problems regarding error handling. There are some places where an
I/O error means that the image is going to be corrupted. I have found that the
only way to fix this is to completely rewrite the thing.

Just sending as an RFC to the list hasn't generated a lot of comments (to be
precise, not a single one). This is a critical part of qcow2 and needs reviews.
So let's try it another way: People in CC, please give it a review. Sooner or
later some of you will need to do so anyway.

Should I apply this series?  I still don't see any review comments.
I sent review comments on the 18th.  I expect Kevin to address them.  I
talked with him on irc while doing the review (i.e. he knows about

You're right, I missed it.  Thanks.


Anthony Liguori


Later, Juan.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]